nixos/networkd: reload instead of restarting #194811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
When its configuration files change, reload systemd-networkd (`networkctl reload`) instead of restarting it. This fixes the following race condition with the current setup during activation: - systemd-networkd.service is stopped - ⚠ someone calls `networkctl`, which immediately restarts networkd, which reconfigures itself using the *old* /etc - the new /etc is set up - systemd-networkd.service is started (doing nothing)
ncfavier
force-pushed
the
networkd-reload
branch
from
c17e753 to
836c0e8
Compare
ncfavier
changed the title
ofborg
bot
added
10.rebuild-darwin: 0
|
I'm not sure if a reload properly reconfigures everything necessary. Did you see systemd/systemd#13452 (comment) ? |
|
Hmm, I did not. I wonder if |
|
Seems like |
|
Do we still want to proceed with this method of reloading? I would say removing existing netdevs is not a big deal compared to the advantages we got with this PR. |
wegank
added
the
12.approvals: 1
wegank
added
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
|
Closing since the network service has since been refactored to distinguish between units that need reload or restart respectively. Furthermore, #359724 should fix any remaining issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When its configuration files change, reload systemd-networkd (
networkctl reload) instead of restarting it.This fixes the following race condition during activation:
networkctl, which immediately restarts networkd, which reconfigures itself using the old /etc