vikunja-desktop: init at 0.24.6

[kolaente]

Description of changes

This PR adds the desktop version of Vikunja. Since it is only an electron wrapper around the frontend and the frontend is already packaged in nixos, this package reuses that.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[kolaente]

Not sure about my change to the release notes, never done that before.

[mweinelt]

The package is not referenced by any top-leve attribute.

[mweinelt]

{"error":"invalid_request","error_description":"The request is missing a required parameter, includes an invalid parameter value, includes a parameter more than once, or is otherwise malformed. The 'redirect_uri' parameter does not match any of the OAuth 2.0 Client's pre-registered redirect urls."}

The app recognized my instance was using SSO to login, but once I click that button I get this error.

Tried both https://example.com as well as https://example.com/api/v1.

[kolaente]

What frontend version is that? You should be able to see that by opening the dev console in the electron shell.

[mweinelt]

The deployment still uses 0.19.1.

Vikunja frontend version 0.19.1

The redirect url is way off.

https://accounts.darmstadt.ccc.de/api/oidc/authorization?client_id=vikunja&redirect_uri=http://127.0.0.1:45735/auth/openid/sso&response_type=code&scope=openid%20email%20profile&state=whrvtu3tmwj

[kolaente]

The deployment still uses 0.19.1.

Let's wait until the frontend update got merged, that should fix the problem.

The redirect url is way off.

I'm afraid there's no way around that. The desktop app spins up a local server to serve frontend files, a redirect back from the provider has to happen there.

[mweinelt]

Please rebase and squash the commits.

[kolaente]

Took me a little longer than I'd like to admit but it should all be correctly rebased now.

[kolaente]

@mweinelt I'm not sure what I need to change so that ofborg works.

[mweinelt]

Will defer to @lilyinstarlight and @winterqt

[maralorn]

I would love to see progress on this, but I have little to no clue about the problem.

[weriomat]

I got it to build locally, but I am not satisfied with the solution of symlinking the frontend before building the app.asar. There might be a better solution, but I don't have enough knowledge to provide one.
I would love to see progress on this and get this merged :)

On a side note, the current (25.05) release notes should probably be updated instead of the 24.11 one.

[weriomat]

On another note, since we do have a monorepo it might be an okay to passthru the src and version in order to not have to bump the version and hash of both vikunja and vikunja-desktop. Any opinions on this idea?

[kolaente]

Thanks for your suggestions!

On another note, since we do have a monorepo it might be an okay to passthru the src and version in order to not have to bump the version and hash of both vikunja and vikunja-desktop. Any opinions on this idea?

I like that idea, also because then we can update the desktop and server packages in one go.

[kolaente]

I've applied the changes and upgraded to 0.24.6. It seems to build and work fine now.

Can I get another review from @lilyinstarlight, @winterqt and maybe @mweinelt or @leona-ya (since you're one of the maintainers of the Vikunja server package)?

[mweinelt]

Starts like that:

Entering my instance (https://todo.darmstadt.ccc.de/api/v1) and clicking CHANGE. No visual feedback.

For each click on CHANGE I see a successful HTTP request against the API, but it will not proceed.

"GET /api/v1/info HTTP/2.0" 200 424 "http://127.0.0.1:45735/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) vikunja-desktop/0.24.6 Chrome/130.0.6723.170 Electron/33.3.1 Safari/537.36"

Edit: Okay, the display changed to this now:

[kolaente]

@mweinelt Looks like you didn't enable cors for your instance.

If you only want to allow connections from Vikunja desktop, you need to enable at least http://localhost:45735 (if that port is taken, it will try port++ until it finds one that's free). Since you're using openid auth, you'll need to make sure that the provider allows redirects back to that host as well.

I was able to verify that the desktop app works with the demo.

[mweinelt]

Why does Vikunja itself not send CORS headers when accessing the API though?

Edit: Can confirm accesing it works after allowing CORS, but now I'm stuck at logging into the OIDC provider using my Passkey 🤡

[kolaente]

Why does Vikunja itself not send CORS headers when accessing the API though?

Because the API can't know in which context it is accessed. That's why each host needs to be allowed explicitly.

A workaround could be to allow access from localhost by default, but that's a Vikunja issue.

[kolaente]

Can confirm accesing it works after allowing CORS, but now I'm stuck at logging into the OIDC provider using my Passkey 🤡

That sounds like a Vikunja issue as well, not sure if that belongs here?

[mweinelt]

Yeah, sorry for mixing issues with our setup and reviewing/testing the app.

[kolaente]

Happy to take an issue in the Vikunja repo