Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sad: fix build on aarch64 #209697

Merged
merged 1 commit into from
Jan 8, 2023
Merged

sad: fix build on aarch64 #209697

merged 1 commit into from
Jan 8, 2023

Conversation

konradmalik
Copy link
Contributor

Description of changes

sad does not compile on aarch64 due to upstream cross-compilation configuration.
For more details see:
#145726 and #107237

This commit fixes compilation on aarch64 and does not break it on x86_64.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from fabaff January 8, 2023 14:13
@figsoda figsoda merged commit 7581ec0 into NixOS:master Jan 8, 2023
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
HanStolpo added a commit to HanStolpo/openobserve-flake that referenced this pull request Sep 24, 2024
@HanStolpo
Add patch to remove .cargo/config.toml to fix aarch64 nix builds
b74ddea 
Using the flake on aarch4-linux in nix leads to an error `error: linker
'aarch64-linux-gnu-gcc' not found` which is apparently fixed by deleting
the `.cargo/config.toml` according to this nixos issue / PR
NixOS/nixpkgs#209697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figsoda figsoda figsoda approved these changes

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@konradmalik @figsoda @Janik-Haag