Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skippy-xd: richardgv/skippy-xd unstable-2023-03-10 -> dreamcat4 0.6.0 #222117

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

jzbor
Copy link
Contributor

@jzbor jzbor commented Mar 20, 2023

Description of changes

Updating to the latest release 0.6.0 and switching to the currently actively maintained fork from dreamcat4.

The changelog to the latest release can be found here although the version currently available seems to be much older.

The fork from dreamcat4 seems to be the currently active fork of this project and sees feature updates as well as fixes for decade-old bugs. It would be nice to have that available in nixpkgs.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Updating to the latest release 0.6.0 and switching to the currently
actively maintained fork from dreamcat4.
@ofborg ofborg bot requested a review from 7c6f434c March 20, 2023 01:55
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Mar 20, 2023
@7c6f434c
Copy link
Member

Leaving a link here: richardgv/skippy-xd#78

@7c6f434c 7c6f434c merged commit 185627e into NixOS:master Mar 22, 2023
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants