-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tree-sitter grammars #242138
Update tree-sitter grammars #242138
Conversation
Update tree-sitter grammars with `update.nix`.
Manually update tree-sitter grammars which don't have a recent release.
Confirmed that this fixes almost all of the errors in Worth merging! |
maybe, we shoudl ping the maintainer. the outdated grammars are quite annoying |
@DPDmancul @figsoda I'm confused why this isn't merged yet, if can help lmk. |
This isn't merged because this introduces some manual updates that might get overwritten by the update script the next time it is updated, and there doesn't seem to be a consensus on whether this PR or #244696 is preferred Also what seems like the original motivation of the update (nvim-treesitter errors) should be resolved now, I wonder if a regular tree-sitter grammar update would be sufficient for your use case? @jasonjckn |
@figsoda yes it is a would, i just need a more recent julia grammar |
This PR has merge conflicts. Can you please rebase your PR |
Also the following should be appended to ignoredTreeSitterOrgRepos = [
"..."
# GitHub org page and actions
".github"
"workflows"
"fuzz-action"
"parse-action"
"parser-setup-action"
"parser-test-action"
"parser-update-action"
"setup-action"
]; |
Description of changes
Updated tree-sitter grammars, both using the
update.nix
and manually updating grammars for which there is no recent release.For a lot of grammars this update is important because they were not compatible with the tree-sitter parser version, leading to errors like nvim-treesitter/nvim-treesitter#3092
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)