Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tree-sitter grammars #242138

Closed
wants to merge 2 commits into from

Conversation

DPDmancul
Copy link
Member

Description of changes

Updated tree-sitter grammars, both using the update.nix and manually updating grammars for which there is no recent release.

For a lot of grammars this update is important because they were not compatible with the tree-sitter parser version, leading to errors like nvim-treesitter/nvim-treesitter#3092

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

DPDmancul added 2 commits July 7, 2023 23:15
Update tree-sitter grammars with `update.nix`.
Manually update tree-sitter grammars which don't have a recent release.
@shazow
Copy link
Contributor

shazow commented Jul 21, 2023

Confirmed that this fixes almost all of the errors in :checkhealth nvim-treesitter, only ones remaining for me is julia, gdscript, and erlang.

Worth merging!

@vale981
Copy link
Contributor

vale981 commented Aug 14, 2023

maybe, we shoudl ping the maintainer. the outdated grammars are quite annoying

@jasonjckn
Copy link

jasonjckn commented Aug 15, 2023

@DPDmancul @figsoda I'm confused why this isn't merged yet, if can help lmk.

@figsoda
Copy link
Member

figsoda commented Aug 15, 2023

This isn't merged because this introduces some manual updates that might get overwritten by the update script the next time it is updated, and there doesn't seem to be a consensus on whether this PR or #244696 is preferred

Also what seems like the original motivation of the update (nvim-treesitter errors) should be resolved now, I wonder if a regular tree-sitter grammar update would be sufficient for your use case? @jasonjckn

@jasonjckn
Copy link

@figsoda yes it is a would, i just need a more recent julia grammar

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 7, 2023
@akirak
Copy link
Contributor

akirak commented Nov 12, 2023

Any updates? The other PR (#244696) has been closed, and quite a few grammars seem to be a bit outdated now.

there doesn't seem to be a consensus on whether this PR or #244696 is preferred

@ck3d
Copy link
Contributor

ck3d commented Mar 14, 2024

This PR has merge conflicts. Can you please rebase your PR

@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@loicreynier
Copy link
Contributor

Also the following should be appended to ignoredTreeSitterOrgRepos in update.nix:

ignoredTreeSitterOrgRepos = [
  "..."
  # GitHub org page and actions
  ".github"
  "workflows"
  "fuzz-action"
  "parse-action"
  "parser-setup-action"
  "parser-test-action"
  "parser-update-action"
  "setup-action"
];

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@fpletz fpletz closed this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants