Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/spice-vdagent: init #266080

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

nixos/spice-vdagent: init #266080

wants to merge 2 commits into from

Conversation

dmytrokyrychuk
Copy link
Contributor

@dmytrokyrychuk dmytrokyrychuk commented Nov 7, 2023 •
edited
Loading

This service can be used in place of the autostart .desktop file that comes with spice-vdagent package. Upstream package ships a similar systemd service since 0.22.0.

Description of changes

Added a spice-vdagent service similar to this: https://gitlab.freedesktop.org/spice/linux/vd_agent/-/blob/aa08162f036840d3e33502dc0a836b03b9cec97c/data/spice-vdagent.service

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@dmytrokyrychuk
nixos/spice-vdagent: init
3fe181c 
This service can be used in place of the autostart .desktop file
that comes with spice-vdagent package. Upstream package ships
a similar systemd service since 0.22.0.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 7, 2023
@dmytrokyrychuk
nixos/tests/spice-vdagent: init
ba2b641 
Add a simple test that verifies that both spice-vdagent and
spice-vdagentd services start when enabled.
@dmytrokyrychuk dmytrokyrychuk marked this pull request as ready for review November 7, 2023 16:11
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 7, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 7, 2023
@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Nov 8, 2023
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 3, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@aucub aucub closed this Dec 19, 2024
@bjornfor
Copy link
Contributor

@aucub: Why did you close it?

@aucub aucub reopened this Dec 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 19, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: tests This PR has tests 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dmytrokyrychuk @bjornfor @delroth @wegank @h7x4 @aucub