wal-lang: init at rev 06498c3f5341ce687a37ad52647f300b72dff52a #266305
Conversation
NixOSInfra
added
the
12. first-time contribution
Avimitin
force-pushed
the
nixos-unstable
branch
from
b9b9000 to
4a3b16e
Compare
|
Changes are all applied. Please make a new review. |
Avimitin
force-pushed
the
nixos-unstable
branch
from
4a3b16e to
f3885af
Compare
|
The commit adding you as a maintainer should be the first commit of this PR with the format: |
Signed-off-by: Avimitin <[email protected]>
Signed-off-by: Avimitin <[email protected]>
Avimitin
force-pushed
the
nixos-unstable
branch
from
f3885af to
5018a73
Compare
|
Should be fixed. Thanks for your review. |
|
Seems like that I can only change the base branch. Is it ok to merge this PR? Or should I open a new one? |
|
A member with the right privileges needs to approve the checks and only a member with merge privileges (not me) can merge this PR. Besides I think other more experienced members also should review this so it follows all the guidelines (: And forgot to say thank you for your contribution to nixpkgs 🎉 |
|
Ok I get that. Anyway, thanks for your review :). |
There was a problem hiding this comment.
This should probably be split into multiple commits, and I think the commit message should be formatted like "wal-lang: init at unstable-2023-08-12".
Additionally, while I don't know much about the project being packaged and using an unstable version might be standard, would it be possible to use a stable release with the dependency updates backported? I assume there's a reason that the new features aren't in a release yet, and Nixpkgs generally packages stable versions when possible.
| @@ -0,0 +1,18 @@ | |||
| { lib, fetchPypi, buildPythonPackage }: | |||
| buildPythonPackage rec { | |||
There was a problem hiding this comment.
There's an extra space at the beginning of this line.
Umm that means we have to maintain a patch for this. Using latest commit will be more convenient. But actually it is stable enough, maybe I should go to upstream and ask them to release a new version. |
|
Seems like the No channel PR action cannot pass successfully. Maybe I should open a new branch and new PR for this package? |
|
Closed the PR for now. I will try to argue with upstream to get new release. And thanks for your review and suggestions! :) |
Description of changes
This PR adds three new packages wal-lang, lark-parser and pylibfst. lark-parser and pylibfst are required by wal-lang, but not presented in python-modules. And we need to use the HEAD revision because the latest release of the wal-lang repository is missing features and has some of the dependencies with security issues.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)