Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: warn about changing docker storageDriver option #268676

Closed
wants to merge 4,907 commits into from

Conversation

con-f-use
Copy link
Contributor

@con-f-use con-f-use commented Nov 20, 2023

Description of changes

Add warning to the documentation of virtualisation.docker.storageDriver that changing will cause any existing containers and images to become inaccessible. see: https://docs.docker.com/storage/storagedriver/select-storage-driver/#check-your-current-storage-driver

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

f2k1de and others added 30 commits October 30, 2023 15:42
(cherry picked from commit 1111114)
(cherry picked from commit 7c98b97)
(partially cherry picked from commit 5852f26)
(cherry picked from commit 63c1a55)
We now use hooks to setup Rust dependencies, rely on upstream's
package.json to compile the Rust code, and support nix-update.

(cherry picked from commit 8aba895)
(cherry picked from commit 3398105)
(cherry picked from commit 2c08ccb)
…-23.05

[23.05] dendrite: 0.12.0 -> 0.13.3
The previous URL explains that documentation has now moved to the new
one.

(cherry picked from commit b29304d)
…-23.05

[Backport release-23.05] wrapFirefox: update URL in comment
…-23.05

[Backport release-23.05] sing-box: 1.5.4 -> 1.5.5
…-23.05

[Backport release-23.05] linux_xanmod, linux_xanmod_latest: 2023-10-21
(cherry picked from commit c3a5719)
(cherry picked from commit c3bf00c)
…fetch-npm-deps-network-error-recovery

[Backport release-23.05] prefetch-npm-deps: add support for NIX_NPM_TOKENS env var; read url bodies within the retry loop
…-23.05

[Backport release-23.05] vencord: 1.6.0 -> 1.6.1
…-23.05

[Backport release-23.05] librewolf-unwrapped: 118.0.1-1 -> 119.0-5
I've excluded the broken packages for now, so that 8.0 can be updated.
After official release those packages should be investigated again.

Also required fixes to excluded new aspnetcore-runtime-compose packages
(which I assume are for the new .NET Docker composite functionality)
…-23.05

[Backport release-23.05] matrix-synapse-unwrapped: 1.95.0 -> 1.95.1
@github-actions github-actions bot added 8.has: changelog 6.topic: emacs Text editor 6.topic: printing 6.topic: rust 6.topic: policy discussion 6.topic: golang 6.topic: ruby 6.topic: vim 6.topic: erlang 6.topic: ocaml 6.topic: xfce The Xfce Desktop Environment 6.topic: fetch 6.topic: stdenv Standard environment 6.topic: nodejs 6.topic: pantheon The Pantheon desktop environment 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: lua 6.topic: cinnamon Desktop environment 6.topic: module system About "NixOS" module system internals 6.topic: systemd 6.topic: nim Nim programing language 6.topic: Enlightenment DE The Enlightenment Desktop Environment 6.topic: mate The MATE Desktop Environment 6.topic: vscode 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library labels Nov 20, 2023
@kirillrdy
Copy link
Member

closing as it pings too many people, please feel fee to open new PR

@kirillrdy kirillrdy closed this Nov 20, 2023
@con-f-use
Copy link
Contributor Author

Oh so sorry, don't know why it targetet a release branch at first.

@NixOS NixOS locked as spam and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
6.topic: cinnamon Desktop environment 6.topic: emacs Text editor 6.topic: Enlightenment DE The Enlightenment Desktop Environment 6.topic: erlang 6.topic: fetch 6.topic: flakes The experimental Nix feature 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: kernel The Linux kernel 6.topic: lib The Nixpkgs function library 6.topic: lua 6.topic: mate The MATE Desktop Environment 6.topic: module system About "NixOS" module system internals 6.topic: nim Nim programing language 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nodejs 6.topic: ocaml 6.topic: pantheon The Pantheon desktop environment 6.topic: policy discussion 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: systemd 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vim 6.topic: vscode 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/`
Projects
None yet
Development

Successfully merging this pull request may close these issues.