Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary disable qtile-extras' strava widget tests #271749

Closed
wants to merge 2 commits into from

Conversation

kirikaza
Copy link
Contributor

@kirikaza kirikaza commented Dec 2, 2023

Fixes nixpkgs/nixos-23.11#271610 by temporarily disabling tests for Strava widget in qtile-extras

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@kirikaza kirikaza changed the base branch from nixos-23.11 to release-23.11 December 2, 2023 20:48
@kirikaza kirikaza marked this pull request as draft December 2, 2023 20:53
@kirikaza kirikaza marked this pull request as ready for review December 2, 2023 20:54
@kirikaza
Copy link
Contributor Author

kirikaza commented Dec 2, 2023

Is it possible to re-run the channel branch check? I changed the target branch, but the check didn't run again.

@kirikaza kirikaza closed this Dec 2, 2023
@kirikaza kirikaza deleted the patch-1 branch December 2, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant