Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtensorflow: 2.13.0 -> 2.14.0 #272838

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

zeuner
Copy link
Contributor

@zeuner zeuner commented Dec 8, 2023

Description of changes

Updated the version and adapted scripts and patches to make it build. Basic tests also succeeded. There remains a warning about ml_dtypes, which might be expected (see #258546 (comment))

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor

Thank you for this work @zeuner !
About ml_dtypes, maybe you could directly go for 2.15.0 ?

@zeuner zeuner force-pushed the tensorflow-2-14 branch 2 times, most recently from f2ee916 to ae92fdd Compare December 8, 2023 10:52
@zeuner
Copy link
Contributor Author

zeuner commented Dec 8, 2023

About ml_dtypes, maybe you could directly go for 2.15.0 ?

In the process of doing so. When I saw 2.15.0, I had already started working on 2.14.0, so I decided to finish it first in order to get all the clang-related changes right. Hope to get it adapted to 2.15.0, soon.

@GaetanLepage
Copy link
Contributor

In the process of doing so. When I saw 2.15.0, I had already started working on 2.14.0, so I decided to finish it first in order to get all the clang-related changes right. Hope to get it adapted to 2.15.0, soon.

Very cool !

@ofborg ofborg bot requested a review from abbradar December 8, 2023 12:48
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Dec 8, 2023
@zeuner zeuner force-pushed the tensorflow-2-14 branch 3 times, most recently from 42cfe4d to fa0d054 Compare December 10, 2023 12:53
@zeuner zeuner marked this pull request as draft December 11, 2023 21:51
@zeuner zeuner force-pushed the tensorflow-2-14 branch 7 times, most recently from bb38de2 to d50895a Compare December 17, 2023 01:59
@zeuner zeuner force-pushed the tensorflow-2-14 branch 3 times, most recently from 0a53960 to 5b66a10 Compare December 25, 2023 13:33
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 28, 2023
@zeuner zeuner mentioned this pull request Jan 4, 2024
13 tasks
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 272838


x86_64-linux

⏩ 28 packages marked as broken and skipped:
  • python311Packages.dm-sonnet
  • python311Packages.dm-sonnet.dist
  • python311Packages.elegy
  • python311Packages.elegy.dist
  • python311Packages.mhcflurry
  • python311Packages.mhcflurry.dist
  • python311Packages.objax
  • python311Packages.objax.dist
  • python311Packages.tensorflow-datasets
  • python311Packages.tensorflow-datasets.dist
  • python311Packages.tf2onnx
  • python311Packages.tf2onnx.dist
  • python311Packages.treex
  • python311Packages.treex.dist
  • python312Packages.elegy
  • python312Packages.elegy.dist
  • python312Packages.mhcflurry
  • python312Packages.mhcflurry.dist
  • python312Packages.objax
  • python312Packages.objax.dist
  • python312Packages.pettingzoo
  • python312Packages.pettingzoo.dist
  • python312Packages.shimmy
  • python312Packages.shimmy.dist
  • python312Packages.tf2onnx
  • python312Packages.tf2onnx.dist
  • python312Packages.treex
  • python312Packages.treex.dist
❌ 86 packages failed to build:
  • minari (python312Packages.minari)
  • minari.dist (python312Packages.minari.dist)
  • python311Packages.ale-py
  • python311Packages.ale-py.dist
  • python311Packages.bambi
  • python311Packages.bambi.dist
  • python311Packages.dalle-mini
  • python311Packages.dalle-mini.dist
  • python311Packages.deepface
  • python311Packages.deepface.dist
  • python311Packages.distrax
  • python311Packages.distrax.dist
  • python311Packages.dm-haiku
  • python311Packages.dm-haiku.dist
  • python311Packages.evosax
  • python311Packages.evosax.dist
  • python311Packages.flax
  • python311Packages.flax.dist
  • python311Packages.flowmc
  • python311Packages.flowmc.dist
  • python311Packages.gymnasium
  • python311Packages.gymnasium.dist
  • python311Packages.minari
  • python311Packages.minari.dist
  • python311Packages.mtcnn
  • python311Packages.mtcnn.dist
  • python311Packages.oryx
  • python311Packages.oryx.dist
  • python311Packages.pettingzoo
  • python311Packages.pettingzoo.dist
  • python311Packages.pymc
  • python311Packages.pymc.dist
  • python311Packages.pytensor
  • python311Packages.pytensor.dist
  • python311Packages.retinaface
  • python311Packages.retinaface.dist
  • python311Packages.rlax
  • python311Packages.rlax.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.skrl
  • python311Packages.skrl.dist
  • python311Packages.torchrl
  • python311Packages.torchrl.dist
  • python311Packages.vqgan-jax
  • python311Packages.vqgan-jax.dist
  • python312Packages.ale-py
  • python312Packages.ale-py.dist
  • python312Packages.bambi
  • python312Packages.bambi.dist
  • python312Packages.cleanlab
  • python312Packages.cleanlab.dist
  • python312Packages.dalle-mini
  • python312Packages.dalle-mini.dist
  • python312Packages.deepface
  • python312Packages.deepface.dist
  • python312Packages.distrax
  • python312Packages.distrax.dist
  • python312Packages.dm-haiku
  • python312Packages.dm-haiku.dist
  • python312Packages.evosax
  • python312Packages.evosax.dist
  • python312Packages.flax
  • python312Packages.flax.dist
  • python312Packages.flowmc
  • python312Packages.flowmc.dist
  • python312Packages.gymnasium
  • python312Packages.gymnasium.dist
  • python312Packages.mtcnn
  • python312Packages.mtcnn.dist
  • python312Packages.oryx
  • python312Packages.oryx.dist
  • python312Packages.pymc
  • python312Packages.pymc.dist
  • python312Packages.pytensor
  • python312Packages.pytensor.dist
  • python312Packages.retinaface
  • python312Packages.retinaface.dist
  • python312Packages.rlax
  • python312Packages.rlax.dist
  • python312Packages.skrl
  • python312Packages.skrl.dist
  • python312Packages.torchrl
  • python312Packages.torchrl.dist
  • python312Packages.vqgan-jax
  • python312Packages.vqgan-jax.dist
✅ 49 packages built:
  • gpt2tc
  • libtensorflow (libtensorflow.python)
  • python311Packages.baselines
  • python311Packages.baselines.dist
  • python311Packages.cleanlab
  • python311Packages.cleanlab.dist
  • python311Packages.edward
  • python311Packages.edward.dist
  • python311Packages.gpt-2-simple
  • python311Packages.gpt-2-simple.dist
  • python311Packages.imgcat
  • python311Packages.imgcat.dist
  • python311Packages.keras
  • python311Packages.keras.dist
  • python311Packages.tensorflow (python311Packages.tensorflow-build ,python311Packages.tensorflowWithoutCuda)
  • python311Packages.tensorflow.dist (python311Packages.tensorflow-build.dist ,python311Packages.tensorflowWithoutCuda.dist)
  • python311Packages.tensorflow-probability
  • python311Packages.tensorflow-probability.dist
  • python311Packages.tensorflowWithCuda
  • python311Packages.tensorflowWithCuda.dist
  • python311Packages.tf-keras
  • python311Packages.tf-keras.dist
  • python311Packages.tflearn
  • python311Packages.tflearn.dist
  • python312Packages.baselines
  • python312Packages.baselines.dist
  • python312Packages.edward
  • python312Packages.edward.dist
  • python312Packages.gpt-2-simple
  • python312Packages.gpt-2-simple.dist
  • python312Packages.imgcat
  • python312Packages.imgcat.dist
  • python312Packages.keras
  • python312Packages.keras.dist
  • python312Packages.tensorflow (python312Packages.tensorflow-build ,python312Packages.tensorflowWithoutCuda)
  • python312Packages.tensorflow.dist (python312Packages.tensorflow-build.dist ,python312Packages.tensorflowWithoutCuda.dist)
  • python312Packages.tensorflow-probability
  • python312Packages.tensorflow-probability.dist
  • python312Packages.tensorflowWithCuda
  • python312Packages.tensorflowWithCuda.dist
  • python312Packages.tf-keras
  • python312Packages.tf-keras.dist
  • python312Packages.tflearn
  • python312Packages.tflearn.dist
  • tests.pkg-config.defaultPkgConfigPackages.tensorflow
  • witnessme
  • witnessme.dist
  • wyoming-openwakeword
  • wyoming-openwakeword.dist

aarch64-linux

⏩ 28 packages marked as broken and skipped:
  • python311Packages.dm-sonnet
  • python311Packages.dm-sonnet.dist
  • python311Packages.elegy
  • python311Packages.elegy.dist
  • python311Packages.mhcflurry
  • python311Packages.mhcflurry.dist
  • python311Packages.objax
  • python311Packages.objax.dist
  • python311Packages.tensorflow-datasets
  • python311Packages.tensorflow-datasets.dist
  • python311Packages.tf2onnx
  • python311Packages.tf2onnx.dist
  • python311Packages.treex
  • python311Packages.treex.dist
  • python312Packages.elegy
  • python312Packages.elegy.dist
  • python312Packages.mhcflurry
  • python312Packages.mhcflurry.dist
  • python312Packages.objax
  • python312Packages.objax.dist
  • python312Packages.pettingzoo
  • python312Packages.pettingzoo.dist
  • python312Packages.shimmy
  • python312Packages.shimmy.dist
  • python312Packages.tf2onnx
  • python312Packages.tf2onnx.dist
  • python312Packages.treex
  • python312Packages.treex.dist
❌ 90 packages failed to build:
  • minari (python312Packages.minari)
  • minari.dist (python312Packages.minari.dist)
  • python311Packages.ale-py
  • python311Packages.ale-py.dist
  • python311Packages.bambi
  • python311Packages.bambi.dist
  • python311Packages.dalle-mini
  • python311Packages.dalle-mini.dist
  • python311Packages.deepface
  • python311Packages.deepface.dist
  • python311Packages.distrax
  • python311Packages.distrax.dist
  • python311Packages.dm-haiku
  • python311Packages.dm-haiku.dist
  • python311Packages.evosax
  • python311Packages.evosax.dist
  • python311Packages.flax
  • python311Packages.flax.dist
  • python311Packages.flowmc
  • python311Packages.flowmc.dist
  • python311Packages.gymnasium
  • python311Packages.gymnasium.dist
  • python311Packages.minari
  • python311Packages.minari.dist
  • python311Packages.mtcnn
  • python311Packages.mtcnn.dist
  • python311Packages.oryx
  • python311Packages.oryx.dist
  • python311Packages.pettingzoo
  • python311Packages.pettingzoo.dist
  • python311Packages.pymc
  • python311Packages.pymc.dist
  • python311Packages.pytensor
  • python311Packages.pytensor.dist
  • python311Packages.retinaface
  • python311Packages.retinaface.dist
  • python311Packages.rlax
  • python311Packages.rlax.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.skrl
  • python311Packages.skrl.dist
  • python311Packages.tensorflowWithCuda
  • python311Packages.tensorflowWithCuda.dist
  • python311Packages.torchrl
  • python311Packages.torchrl.dist
  • python311Packages.vqgan-jax
  • python311Packages.vqgan-jax.dist
  • python312Packages.ale-py
  • python312Packages.ale-py.dist
  • python312Packages.bambi
  • python312Packages.bambi.dist
  • python312Packages.cleanlab
  • python312Packages.cleanlab.dist
  • python312Packages.dalle-mini
  • python312Packages.dalle-mini.dist
  • python312Packages.deepface
  • python312Packages.deepface.dist
  • python312Packages.distrax
  • python312Packages.distrax.dist
  • python312Packages.dm-haiku
  • python312Packages.dm-haiku.dist
  • python312Packages.evosax
  • python312Packages.evosax.dist
  • python312Packages.flax
  • python312Packages.flax.dist
  • python312Packages.flowmc
  • python312Packages.flowmc.dist
  • python312Packages.gymnasium
  • python312Packages.gymnasium.dist
  • python312Packages.mtcnn
  • python312Packages.mtcnn.dist
  • python312Packages.oryx
  • python312Packages.oryx.dist
  • python312Packages.pymc
  • python312Packages.pymc.dist
  • python312Packages.pytensor
  • python312Packages.pytensor.dist
  • python312Packages.retinaface
  • python312Packages.retinaface.dist
  • python312Packages.rlax
  • python312Packages.rlax.dist
  • python312Packages.skrl
  • python312Packages.skrl.dist
  • python312Packages.tensorflowWithCuda
  • python312Packages.tensorflowWithCuda.dist
  • python312Packages.torchrl
  • python312Packages.torchrl.dist
  • python312Packages.vqgan-jax
  • python312Packages.vqgan-jax.dist
✅ 44 packages built:
  • libtensorflow (libtensorflow.python)
  • python311Packages.baselines
  • python311Packages.baselines.dist
  • python311Packages.cleanlab
  • python311Packages.cleanlab.dist
  • python311Packages.edward
  • python311Packages.edward.dist
  • python311Packages.gpt-2-simple
  • python311Packages.gpt-2-simple.dist
  • python311Packages.imgcat
  • python311Packages.imgcat.dist
  • python311Packages.keras
  • python311Packages.keras.dist
  • python311Packages.tensorflow (python311Packages.tensorflow-build ,python311Packages.tensorflowWithoutCuda)
  • python311Packages.tensorflow.dist (python311Packages.tensorflow-build.dist ,python311Packages.tensorflowWithoutCuda.dist)
  • python311Packages.tensorflow-probability
  • python311Packages.tensorflow-probability.dist
  • python311Packages.tf-keras
  • python311Packages.tf-keras.dist
  • python311Packages.tflearn
  • python311Packages.tflearn.dist
  • python312Packages.baselines
  • python312Packages.baselines.dist
  • python312Packages.edward
  • python312Packages.edward.dist
  • python312Packages.gpt-2-simple
  • python312Packages.gpt-2-simple.dist
  • python312Packages.imgcat
  • python312Packages.imgcat.dist
  • python312Packages.keras
  • python312Packages.keras.dist
  • python312Packages.tensorflow (python312Packages.tensorflow-build ,python312Packages.tensorflowWithoutCuda)
  • python312Packages.tensorflow.dist (python312Packages.tensorflow-build.dist ,python312Packages.tensorflowWithoutCuda.dist)
  • python312Packages.tensorflow-probability
  • python312Packages.tensorflow-probability.dist
  • python312Packages.tf-keras
  • python312Packages.tf-keras.dist
  • python312Packages.tflearn
  • python312Packages.tflearn.dist
  • tests.pkg-config.defaultPkgConfigPackages.tensorflow
  • witnessme
  • witnessme.dist
  • wyoming-openwakeword
  • wyoming-openwakeword.dist

x86_64-darwin

⏩ 71 packages marked as broken and skipped:
  • libtensorflow
  • libtensorflow.python
  • python311Packages.bambi
  • python311Packages.bambi.dist
  • python311Packages.cleanlab
  • python311Packages.cleanlab.dist
  • python311Packages.dm-sonnet
  • python311Packages.dm-sonnet.dist
  • python311Packages.mhcflurry
  • python311Packages.mhcflurry.dist
  • python311Packages.objax
  • python311Packages.objax.dist
  • python311Packages.oryx
  • python311Packages.oryx.dist
  • python311Packages.pymc
  • python311Packages.pymc.dist
  • python311Packages.pytensor
  • python311Packages.pytensor.dist
  • python311Packages.tensorflow-datasets
  • python311Packages.tensorflow-datasets.dist
  • python311Packages.tf2onnx
  • python311Packages.tf2onnx.dist
  • python312Packages.bambi
  • python312Packages.bambi.dist
  • python312Packages.baselines
  • python312Packages.baselines.dist
  • python312Packages.cleanlab
  • python312Packages.cleanlab.dist
  • python312Packages.deepface
  • python312Packages.deepface.dist
  • python312Packages.edward
  • python312Packages.edward.dist
  • python312Packages.gpt-2-simple
  • python312Packages.gpt-2-simple.dist
  • python312Packages.imgcat
  • python312Packages.imgcat.dist
  • python312Packages.keras
  • python312Packages.keras.dist
  • python312Packages.mhcflurry
  • python312Packages.mhcflurry.dist
  • python312Packages.mtcnn
  • python312Packages.mtcnn.dist
  • python312Packages.objax
  • python312Packages.objax.dist
  • python312Packages.oryx
  • python312Packages.oryx.dist
  • python312Packages.pymc
  • python312Packages.pymc.dist
  • python312Packages.pytensor
  • python312Packages.pytensor.dist
  • python312Packages.retinaface
  • python312Packages.retinaface.dist
  • python312Packages.tensorflow
  • python312Packages.tensorflow-build
  • python312Packages.tensorflow-build.dist
  • python312Packages.tensorflow-probability
  • python312Packages.tensorflow-probability.dist
  • python312Packages.tensorflow.dist
  • python312Packages.tensorflowWithoutCuda
  • python312Packages.tensorflowWithoutCuda.dist
  • python312Packages.tf-keras
  • python312Packages.tf-keras.dist
  • python312Packages.tf2onnx
  • python312Packages.tf2onnx.dist
  • python312Packages.tflearn
  • python312Packages.tflearn.dist
  • tests.pkg-config.defaultPkgConfigPackages.tensorflow
  • witnessme
  • witnessme.dist
  • wyoming-openwakeword
  • wyoming-openwakeword.dist
❌ 24 packages failed to build:
  • python311Packages.baselines
  • python311Packages.baselines.dist
  • python311Packages.deepface
  • python311Packages.deepface.dist
  • python311Packages.edward
  • python311Packages.edward.dist
  • python311Packages.gpt-2-simple
  • python311Packages.gpt-2-simple.dist
  • python311Packages.imgcat
  • python311Packages.imgcat.dist
  • python311Packages.keras
  • python311Packages.keras.dist
  • python311Packages.mtcnn
  • python311Packages.mtcnn.dist
  • python311Packages.retinaface
  • python311Packages.retinaface.dist
  • python311Packages.tensorflow (python311Packages.tensorflow-build ,python311Packages.tensorflowWithoutCuda)
  • python311Packages.tensorflow.dist (python311Packages.tensorflow-build.dist ,python311Packages.tensorflowWithoutCuda.dist)
  • python311Packages.tensorflow-probability
  • python311Packages.tensorflow-probability.dist
  • python311Packages.tf-keras
  • python311Packages.tf-keras.dist
  • python311Packages.tflearn
  • python311Packages.tflearn.dist

aarch64-darwin

⏩ 89 packages marked as broken and skipped:
  • libtensorflow
  • libtensorflow.python
  • python311Packages.cleanlab
  • python311Packages.cleanlab.dist
  • python311Packages.dalle-mini
  • python311Packages.dalle-mini.dist
  • python311Packages.dm-sonnet
  • python311Packages.dm-sonnet.dist
  • python311Packages.elegy
  • python311Packages.elegy.dist
  • python311Packages.mhcflurry
  • python311Packages.mhcflurry.dist
  • python311Packages.objax
  • python311Packages.objax.dist
  • python311Packages.tensorflow-datasets
  • python311Packages.tensorflow-datasets.dist
  • python311Packages.tf2onnx
  • python311Packages.tf2onnx.dist
  • python311Packages.treex
  • python311Packages.treex.dist
  • python312Packages.bambi
  • python312Packages.bambi.dist
  • python312Packages.baselines
  • python312Packages.baselines.dist
  • python312Packages.cleanlab
  • python312Packages.cleanlab.dist
  • python312Packages.dalle-mini
  • python312Packages.dalle-mini.dist
  • python312Packages.deepface
  • python312Packages.deepface.dist
  • python312Packages.distrax
  • python312Packages.distrax.dist
  • python312Packages.dm-haiku
  • python312Packages.dm-haiku.dist
  • python312Packages.edward
  • python312Packages.edward.dist
  • python312Packages.elegy
  • python312Packages.elegy.dist
  • python312Packages.evosax
  • python312Packages.evosax.dist
  • python312Packages.flax
  • python312Packages.flax.dist
  • python312Packages.flowmc
  • python312Packages.flowmc.dist
  • python312Packages.gpt-2-simple
  • python312Packages.gpt-2-simple.dist
  • python312Packages.imgcat
  • python312Packages.imgcat.dist
  • python312Packages.keras
  • python312Packages.keras.dist
  • python312Packages.mhcflurry
  • python312Packages.mhcflurry.dist
  • python312Packages.mtcnn
  • python312Packages.mtcnn.dist
  • python312Packages.objax
  • python312Packages.objax.dist
  • python312Packages.oryx
  • python312Packages.oryx.dist
  • python312Packages.pymc
  • python312Packages.pymc.dist
  • python312Packages.pytensor
  • python312Packages.pytensor.dist
  • python312Packages.retinaface
  • python312Packages.retinaface.dist
  • python312Packages.rlax
  • python312Packages.rlax.dist
  • python312Packages.tensorflow
  • python312Packages.tensorflow-build
  • python312Packages.tensorflow-build.dist
  • python312Packages.tensorflow-probability
  • python312Packages.tensorflow-probability.dist
  • python312Packages.tensorflow.dist
  • python312Packages.tensorflowWithoutCuda
  • python312Packages.tensorflowWithoutCuda.dist
  • python312Packages.tf-keras
  • python312Packages.tf-keras.dist
  • python312Packages.tf2onnx
  • python312Packages.tf2onnx.dist
  • python312Packages.tflearn
  • python312Packages.tflearn.dist
  • python312Packages.treex
  • python312Packages.treex.dist
  • python312Packages.vqgan-jax
  • python312Packages.vqgan-jax.dist
  • tests.pkg-config.defaultPkgConfigPackages.tensorflow
  • witnessme
  • witnessme.dist
  • wyoming-openwakeword
  • wyoming-openwakeword.dist
❌ 46 packages failed to build:
  • python311Packages.bambi
  • python311Packages.bambi.dist
  • python311Packages.baselines
  • python311Packages.baselines.dist
  • python311Packages.deepface
  • python311Packages.deepface.dist
  • python311Packages.distrax
  • python311Packages.distrax.dist
  • python311Packages.dm-haiku
  • python311Packages.dm-haiku.dist
  • python311Packages.edward
  • python311Packages.edward.dist
  • python311Packages.evosax
  • python311Packages.evosax.dist
  • python311Packages.flax
  • python311Packages.flax.dist
  • python311Packages.flowmc
  • python311Packages.flowmc.dist
  • python311Packages.gpt-2-simple
  • python311Packages.gpt-2-simple.dist
  • python311Packages.imgcat
  • python311Packages.imgcat.dist
  • python311Packages.keras
  • python311Packages.keras.dist
  • python311Packages.mtcnn
  • python311Packages.mtcnn.dist
  • python311Packages.oryx
  • python311Packages.oryx.dist
  • python311Packages.pymc
  • python311Packages.pymc.dist
  • python311Packages.pytensor
  • python311Packages.pytensor.dist
  • python311Packages.retinaface
  • python311Packages.retinaface.dist
  • python311Packages.rlax
  • python311Packages.rlax.dist
  • python311Packages.tensorflow (python311Packages.tensorflow-build ,python311Packages.tensorflowWithoutCuda)
  • python311Packages.tensorflow.dist (python311Packages.tensorflow-build.dist ,python311Packages.tensorflowWithoutCuda.dist)
  • python311Packages.tensorflow-probability
  • python311Packages.tensorflow-probability.dist
  • python311Packages.tf-keras
  • python311Packages.tf-keras.dist
  • python311Packages.tflearn
  • python311Packages.tflearn.dist
  • python311Packages.vqgan-jax
  • python311Packages.vqgan-jax.dist

@boltzmannrain
Copy link
Contributor

aarch64-linux hash

$ nix-build --system aarch64-linux -A python312Packages.tensorflowWithCuda
...
error: hash mismatch in fixed-output derivation '/nix/store/dkh4r650lvmkwgc1vgbnn61gdwpiif0k-tensorflow-gpu-2.14.0-deps.tar.gz.drv':
                specified: sha256-AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=
                   got:    sha256-9Al7JH93Q7D0xN5sjtk5VvZH+ge13nnMJOC8Py5f96g=

@boltzmannrain
Copy link
Contributor

Got local mismatch without cuda

$ nix-build --system aarch64-linux -A python312Packages.tensorflow -j0
...
error: hash mismatch in fixed-output derivation '/nix/store/icicrg8manx86yywyyf0d833ckxnb9za-tensorflow-2.14.0-deps.tar.gz.drv':
                specified: sha256-ktEpU1YyedNpssuJTqsqS+XeY5NFNFnH1fuHsm4NRSY=
                   got:    sha256-85xKq/gKO9Klt56OBCowTFhYvz+61vSofODFGUio17s=

it is possible to download ofborg-built outputs?

@zeuner
Copy link
Contributor Author

zeuner commented Nov 7, 2024

Thanks, learned something new. I "enabled" cudaSupport by building tensorflowWithCuda before, which did not trigger this. Should be fixed now.

Yes, they are slightly different. tensorflowWithCuda only overrides the cudaSupport argument for the tensorflow package, while enabling cudaSupport globally will affect the entire nixpkgs package set.

Yes... in our case, the thing is that cudaCapabilities is currently conditionalized on config.cudaSupport, so it doesn't pick up cudaPackages.cudaFlags.cudaCapabilities when building as tensorflowWithCuda, but it does so when globally setting the config flag (https://github.com/NixOS/nixpkgs/pull/272838/files#diff-3f9c997aafe20e8949648d4babbf03af7c4864c517b7cf3611d6a6e42610257aL74).

Not sure whether this is sensible, though. Maybe it slipped through when I considered the global push for preferably using cudaSupport from config instead of overrides. And maybe it's better to have the same behaviour regarding cudaCapabilities no matter how cudaSupport got enabled.

@zeuner
Copy link
Contributor Author

zeuner commented Nov 7, 2024

  • python311Packages.shimmy

These confuse me a bit. AFAICS, python3Packages.shimmy does not depend on python3Packages.tensorflow or python3Packages.keras (the packages being touched by this PR), so I'm not sure what I could do about it. Am I missing something here?

@zeuner
Copy link
Contributor Author

zeuner commented Nov 7, 2024

Got local mismatch without cuda

$ nix-build --system aarch64-linux -A python312Packages.tensorflow -j0
...
error: hash mismatch in fixed-output derivation '/nix/store/icicrg8manx86yywyyf0d833ckxnb9za-tensorflow-2.14.0-deps.tar.gz.drv':
                specified: sha256-ktEpU1YyedNpssuJTqsqS+XeY5NFNFnH1fuHsm4NRSY=
                   got:    sha256-85xKq/gKO9Klt56OBCowTFhYvz+61vSofODFGUio17s=

it is possible to download ofborg-built outputs?

Good question!

@NixOS/infra any ideas regarding this?

@zeuner
Copy link
Contributor Author

zeuner commented Nov 10, 2024

aarch64-linux hash

$ nix-build --system aarch64-linux -A python312Packages.tensorflowWithCuda
...
error: hash mismatch in fixed-output derivation '/nix/store/dkh4r650lvmkwgc1vgbnn61gdwpiif0k-tensorflow-gpu-2.14.0-deps.tar.gz.drv':
                specified: sha256-AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=
                   got:    sha256-9Al7JH93Q7D0xN5sjtk5VvZH+ge13nnMJOC8Py5f96g=

Thanks, added.

@zeuner
Copy link
Contributor Author

zeuner commented Nov 10, 2024

  • python311Packages.shimmy

These confuse me a bit. AFAICS, python3Packages.shimmy does not depend on python3Packages.tensorflow or python3Packages.keras (the packages being touched by this PR), so I'm not sure what I could do about it. Am I missing something here?

I could also build it here on with this PR merged.

@zeuner zeuner force-pushed the tensorflow-2-14 branch 2 times, most recently from ee5c89d to 0bd2b4f Compare November 17, 2024 22:14
@zeuner
Copy link
Contributor Author

zeuner commented Nov 17, 2024

Figured out that pypi_psutil led to the deps hashes being unstable on aarch64-linux. They need to be recomputed now, but should hopefully be stable afterwards.

@FliegendeWurst
Copy link
Member

ofborg reports the hash to be sha256-KXSbqwZpN4Im32St0ADyIc4N5/SQfiQPDoLu9bXbckY=.

@FliegendeWurst FliegendeWurst added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 4, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 16, 2024
@zeuner zeuner force-pushed the tensorflow-2-14 branch 2 times, most recently from f56ffff to be2f4e9 Compare January 2, 2025 20:44
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 4, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants