buildNpmPackage: use env vars #280623
Closed
buildNpmPackage: use env vars #280623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fresheyeball
requested review from
lilyinstarlight and
winterqt
as code owners
|
A potentially not good PR I made on top of this one that fixes an issue with HOME Fresheyeball#2 |
dotlambda
changed the title
dotlambda
approved these changes
Jan 31, 2024
wegank
added
the
12.approvals: 1
wegank
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
github-actions
bot
added
10.rebuild-darwin: 501-1000
10.rebuild-linux: 2501-5000
and removed
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
labels
wegank
removed
the
12.approvals: 1
5 tasks
|
Closing in favor of the rebased #373220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Ayyyyyeee, you know it should be env vars not .npmrc that we use to set settings. That way we can use the hook in a nix shell without modifying the user's state. You know?
Things done
I tested this via usage of the hook in a nix shell, worked.