Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various VSCode / VSCodium extension themes #280922

Closed
wants to merge 1 commit into from

Conversation

D3vil0p3r
Copy link
Member

@D3vil0p3r D3vil0p3r commented Jan 14, 2024

Description of changes

vscode-extensions.carrie999.cyberpunk-2020: init at 0.1.4
vscode-extensions.dhedgecock.radical-vscode: init at 3.3.1
vscode-extensions.nur.just-black: init at 3.1.1
vscode-extensions.silofy.hackthebox: init at 0.2.9
vscode-extensions.thorerik.hacker-theme: init at 3.0.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to target master branch for new packages.

To avoid mass-pinging everyone, please also follow the guide in contributing.md that explains the rebase commands necessary to switch the branch.

Commits should also be split up, one commit per package.

@drupol
Copy link
Contributor

drupol commented Jan 14, 2024

Tip: Set your PR in draft to avoid spamming all maintainers before doing the branch change.

@D3vil0p3r D3vil0p3r marked this pull request as draft January 14, 2024 12:52
@D3vil0p3r
Copy link
Member Author

I prefer to close this PR in favor of #280941

@D3vil0p3r D3vil0p3r closed this Jan 14, 2024
@D3vil0p3r D3vil0p3r deleted the patch-4 branch January 14, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants