Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-dist: 0.5.0 -> 0.7.2 #281911

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

mistydemeo
Copy link
Contributor

Description of changes

This updates cargo-dist to the latest current release, 0.7.2.

I removed an extra set of package tests because these currently assume a git repo has been checked out. I'm a developer on the project and it's an oversight on our part; we've only tested cargo test from within a git checkout. I'll look into fixing it for a future version.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@lf- lf- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Please consider adding yourself to maintainers for the package given that you work on this upstream, so that you will receive pings if something goes awry or there are updates :)

In the next release, consider adding passthru.updateScript = nix-update-script { };, which will make the r-ryantm bot submit update PRs automatically and ping you with them. Currently there is a bug in nix-update which makes it catch prerelease versions, but I have a PR pending to fix that, and after that's merged, it's worth setting up auto-update on this package by adding that line. Mic92/nix-update#221

Edit: for more info on the auto update infrastructure see this manual section: https://nixos.org/manual/nixpkgs/unstable/#var-passthru-updateScript

@mistydemeo
Copy link
Contributor Author

lgtm. Please consider adding yourself to maintainers for the package given that you work on this upstream, so that you will receive pings if something goes awry or there are updates :)

Sounds good - I'll do that in the next release!

In the next release, consider adding passthru.updateScript = nix-update-script { };, which will make the r-ryantm bot submit update PRs automatically and ping you with them. Currently there is a bug in nix-update which makes it catch prerelease versions, but I have a PR pending to fix that, and after that's merged, it's worth setting up auto-update on this package by adding that line.

Interesting! Good to know, I'll do this in the next release once your fix is in.

@matthiasbeyer matthiasbeyer merged commit 9751adf into NixOS:master Jan 19, 2024
28 checks passed
@mistydemeo mistydemeo deleted the update_cargo-dist branch January 19, 2024 05:40
@mistydemeo mistydemeo mentioned this pull request Jan 22, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants