Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audiveris: init at 5.3.1 #282848

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

audiveris: init at 5.3.1 #282848

wants to merge 1 commit into from

Conversation

zeuner
Copy link
Contributor

@zeuner zeuner commented Jan 22, 2024

Description of changes

Adding Audiveris, an open source OMR (optical music recognition) engine capable of generating MusicXML files from scanned music scores: https://audiveris.github.io/audiveris/

This is my first attempt on a gradle-based package, so feel free to suggest improvements. By now, it's already usable, though.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@chayleaf
Copy link
Contributor

chayleaf commented Jul 15, 2024

#272380 got merged, so you should adapt this (it should greatly simplify the code). See https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/gradle.section.md

@FliegendeWurst FliegendeWurst added the awaiting_changes (old Marvin label, do not use) label Nov 17, 2024
@twz123 twz123 mentioned this pull request Dec 4, 2024
13 tasks
@zeuner
Copy link
Contributor Author

zeuner commented Dec 26, 2024

#272380 got merged, so you should adapt this (it should greatly simplify the code). See https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/gradle.section.md

@chayleaf Full ACK. When I wrote the PR, I think mitmCache wasn't widely used, so I took the approach I saw in other packages. Updated the PR accordingly.

(CC @FliegendeWurst)

@FliegendeWurst FliegendeWurst removed the awaiting_changes (old Marvin label, do not use) label Dec 26, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 labels Dec 26, 2024
@FliegendeWurst
Copy link
Member

Build for platforms other than x64 Linux fails due to #365375.

      > Could not find tesseract-5.3.1-1.5.9-linux-arm64.jar (org.bytedeco:tesseract:5.3.1-1.5.9).
        Searched in the following locations:
            https://repo.maven.apache.org/maven2/org/bytedeco/tesseract/5.3.1-1.5.9/tesseract-5.3.1-1.5.9-linux-arm64.jar
      > Could not find leptonica-1.83.0-1.5.9-linux-arm64.jar (org.bytedeco:leptonica:1.83.0-1.5.9).
        Searched in the following locations:
            https://repo.maven.apache.org/maven2/org/bytedeco/leptonica/1.83.0-1.5.9/leptonica-1.83.0-1.5.9-linux-arm64.jar

Please mark as broken or fix the fetch invocation (I am not sure how to do that here..)

@zeuner
Copy link
Contributor Author

zeuner commented Jan 2, 2025

Build for platforms other than x64 Linux fails due to #365375.

      > Could not find tesseract-5.3.1-1.5.9-linux-arm64.jar (org.bytedeco:tesseract:5.3.1-1.5.9).
        Searched in the following locations:
            https://repo.maven.apache.org/maven2/org/bytedeco/tesseract/5.3.1-1.5.9/tesseract-5.3.1-1.5.9-linux-arm64.jar
      > Could not find leptonica-1.83.0-1.5.9-linux-arm64.jar (org.bytedeco:leptonica:1.83.0-1.5.9).
        Searched in the following locations:
            https://repo.maven.apache.org/maven2/org/bytedeco/leptonica/1.83.0-1.5.9/leptonica-1.83.0-1.5.9-linux-arm64.jar

Please mark as broken or fix the fetch invocation (I am not sure how to do that here..)

Thanks for pointing this out. I wasn't aware of this kind of platform dependency, and it doesn't seem to be mentioned in the gradle language framework docs.

Trying your approach from #366098 now.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants