Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autobrr: init at 1.57.0 #287593

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

autobrr: init at 1.57.0 #287593

wants to merge 3 commits into from
+216 −0

Conversation

av-gal
Copy link

@av-gal av-gal commented Feb 9, 2024 •
edited
Loading

Description of changes

Reopening #283389. Closes #224560.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 9, 2024
@av-gal av-gal mentioned this pull request Feb 9, 2024
Merged
13 tasks
dotlambda
dotlambda requested changes Feb 9, 2024
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three commits please:

  • maintainers: add av-gal
  • autobrr: init at 1.36.0
  • nixos/autobrr: init

maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
nixos/doc/manual/release-notes/rl-2405.section.md Outdated Show resolved Hide resolved
nixos/modules/module-list.nix Outdated Show resolved Hide resolved
pkgs/by-name/au/autobrr/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/au/autobrr/package.nix Show resolved Hide resolved
pkgs/by-name/au/autobrr/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/au/autobrr/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/au/autobrr/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/au/autobrr/package.nix Outdated Show resolved Hide resolved
@dotlambda dotlambda changed the title Autobrr: add package/module/test for autobrr, attempt #2 autobrr: init at 1.36.0 Feb 9, 2024
@av-gal av-gal force-pushed the autobrr branch 2 times, most recently from b9da876 to f8fbc72 Compare February 9, 2024 22:55
av-gal

This comment was marked as duplicate.

Sign in to view

@av-gal av-gal requested a review from dotlambda February 9, 2024 22:57
@av-gal
Copy link
Author

av-gal commented Feb 9, 2024 •
edited
Loading

I think I've addressed all remaining concerns. @ambroisie please let me know if I've missed anything from your original review.

dotlambda
dotlambda reviewed Feb 9, 2024
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a settings option to create config.toml. See NixOS/rfcs#42.

nixos/modules/services/misc/autobrr.nix Outdated Show resolved Hide resolved
pkgs/by-name/au/autobrr/package.nix Outdated Show resolved Hide resolved
ambroisie
ambroisie requested changes Feb 9, 2024
View reviewed changes
nixos/modules/services/misc/autobrr.nix Outdated Show resolved Hide resolved
pkgs/by-name/au/autobrr/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/au/autobrr/package.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Feb 9, 2024
@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Feb 10, 2024
fsnkty
fsnkty suggested changes Feb 14, 2024
View reviewed changes
nixos/modules/services/misc/autobrr.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/autobrr.nix Outdated Show resolved Hide resolved
@zze0s
Copy link

zze0s commented Feb 14, 2024

We just released v1.38.0 so might be a good idea to bump the version in this pr 😄

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@SuperSandro2000 SuperSandro2000 mentioned this pull request Jun 6, 2024
Closed
12 tasks
@muradbu
Copy link

muradbu commented Jul 23, 2024

Is this still being worked on?

@gepbird gepbird added the awaiting_changes (old Marvin label, do not use) label Nov 14, 2024
@av-gal
Copy link
Author

av-gal commented Nov 22, 2024

I plan on picking this up again shortly.

@zze0s
Copy link

zze0s commented Nov 22, 2024

Great! The move to pnpm was the most recent big build related changes but other than that it should be smooth sailing.

Current version is 1.50.0 :)

@av-gal av-gal marked this pull request as draft December 9, 2024 06:05
@av-gal
Copy link
Author

av-gal commented Dec 9, 2024 •
edited
Loading

Addressed most of your suggestions @gepbird, thanks for the feedback. Still need to fix the update script, and a new issue related to fetchGithub not retrieving the commit hash when it downloads the repository archive. Marking as this as draft again until I get those issues fixed.

@av-gal av-gal changed the title autobrr: init at 1.52.0 autobrr: init at 1.53.0 Dec 10, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
@av-gal av-gal mentioned this pull request Dec 17, 2024
Closed
@SigmaSquadron SigmaSquadron removed the awaiting_changes (old Marvin label, do not use) label Jan 5, 2025
@av-gal av-gal changed the title autobrr: init at 1.53.0 autobrr: init at 1.56.1 Jan 6, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 6, 2025
@av-gal av-gal marked this pull request as ready for review January 6, 2025 06:31
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Jan 6, 2025
gepbird
gepbird reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the above issue, changes LGTM!

Tested the update script, building the package, running the test, basic functionality of the binaries.

pkgs/by-name/au/autobrr/package.nix Show resolved Hide resolved
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Jan 7, 2025
@zze0s
Copy link

zze0s commented Jan 7, 2025

Yesterday we released v1.57.0 No changes to the build etc.

@av-gal av-gal changed the title autobrr: init at 1.56.1 autobrr: init at 1.57.0 Jan 7, 2025
gepbird
gepbird approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as before, I think this is ready :)

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 287593

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • autobrr

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsnkty fsnkty fsnkty requested changes

@BatteredBunny BatteredBunny BatteredBunny approved these changes

@gepbird gepbird gepbird approved these changes

@ambroisie ambroisie Awaiting requested review from ambroisie

@dotlambda dotlambda Awaiting requested review from dotlambda

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: tests This PR has tests 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: autobrr