-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FerretDB document defaults, PostgreSQL default URL, disable telemetry #288493
Open
minijackson
wants to merge
3
commits into
NixOS:master
Choose a base branch
from
minijackson:ferretdb-document-defaults
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
labels
Feb 13, 2024
ofborg
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
labels
Feb 13, 2024
minijackson
force-pushed
the
ferretdb-document-defaults
branch
from
May 13, 2024 11:32
ff7ba3b
to
e5fe078
Compare
Friendly ping: @JulienMalka @camillemndn |
FerretDB developer there. Why disable telemetry by default? |
@AlekSi hey! It's kind of an unwritten rule inside of nixpkgs to disable telemetry by default. Some of our users expect it. |
Running the |
minijackson
force-pushed
the
ferretdb-document-defaults
branch
2 times, most recently
from
October 25, 2024 09:36
e391c28
to
4485e82
Compare
minijackson
force-pushed
the
ferretdb-document-defaults
branch
from
January 14, 2025 09:33
4485e82
to
808cabf
Compare
so that they are documented in the options list
provides a nice default if the end user wants to use the PostgreSQL backend
minijackson
force-pushed
the
ferretdb-document-defaults
branch
from
January 14, 2025 09:39
808cabf
to
08f1820
Compare
@JulienMalka done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)cc @JulienMalka @camillemndn
Add a 👍 reaction to pull requests you find important.