-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/prometheus: add mqtt-exporter #289395
Conversation
7ca4297
to
36558e8
Compare
Ping :^) |
36558e8
to
27ac05e
Compare
27ac05e
to
0160cba
Compare
0160cba
to
c47067c
Compare
9f5d406
to
4220028
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4627 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nixos/modules/services/monitoring/prometheus/exporters/mqtt.nix
Outdated
Show resolved
Hide resolved
4220028
to
53a34ea
Compare
Thanks for the review! Fixed your suggestion. |
53a34ea
to
2b5b5d6
Compare
2b5b5d6
to
ec86627
Compare
I've now also added a check phase using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to have a prometheus maintainer review
ec86627
to
08a0bbd
Compare
08a0bbd
to
8cfed61
Compare
Signed-off-by: Christoph Heiss <[email protected]>
Signed-off-by: Christoph Heiss <[email protected]>
Signed-off-by: Christoph Heiss <[email protected]>
8cfed61
to
345d36a
Compare
Package has been added in #360486 separately .. |
Description of changes
This adds mqtt-exporter, a MQTT exporter for Prometheus, as a package itself.Adds a corresponding
services.prometheus.exporters.mqtt
exporter, such that it can be easily configured & enabled. As well as a test for it, as it should be.Depends on #288219.Obsoleted by 1.4.2
Two patches are unfortunaly (currently) needed, one for providing some basic pyproject properties to allow it to build successfully, as upstream does not have[project]
defined in theirpyproject.toml
, as well as not havesetup.{cfg,py}
. We could also manually assemble the package I guess, but that seemed like a pretty clean solution to me - or there is some even better solution?Second patch addresses the lack of a configuration option to set the port the metrics exporter should listen on, which is an common option pre-defined for all exporters.I intend to upstream both patches - in fact, I have already sent a PR upstream with both of them, so hopefully they can be dropped soon.Both changes have been merged upstream, so they can be dropped with the next release. 🚀Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.