glsl_analyzer: init at 1.4.5

[wr7]

Description of changes

Created a package for glsl_analyzer. This is a language server for the OpenGL Shading Language. Currently the only other GLSL language server on Nix is glslls, but it's slightly buggy and has worse descriptions compared to glsl_analyzer.

I've been using this package for a while, it seems to fully work.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[wr7]

It seems that the Darwin build failed with error: unable to create compilation: DarwinSdkNotFound. This seems like an issue with upstream Zig. The only reference that I could find to this is here. I'm just going to add Darwin as a badPlatform.

[purcell]

It seems that the Darwin build failed with error: unable to create compilation: DarwinSdkNotFound. This seems like an issue with upstream Zig. The only reference that I could find to this is ziglang/zig#10217 (comment). I'm just going to add Darwin as a badPlatform.

Zig in nixpkgs fails to build on aarch64-darwin with exactly that error when the sandbox is enabled. I found this locally in an unrelated setting and disabling the sandbox fixed it.

[purcell]

It seems that the Darwin build failed with error: unable to create compilation: DarwinSdkNotFound. This seems like an issue with upstream Zig. The only reference that I could find to this is ziglang/zig#10217 (comment). I'm just going to add Darwin as a badPlatform.

Zig in nixpkgs fails to build on aarch64-darwin with exactly that error when the sandbox is enabled. I found this locally in an unrelated setting and disabling the sandbox fixed it.

[wr7]

It seems that the Darwin build failed with error: unable to create compilation: DarwinSdkNotFound. This seems like an issue with upstream Zig. The only reference that I could find to this is ziglang/zig#10217 (comment). I'm just going to add Darwin as a badPlatform.

Zig in nixpkgs fails to build on aarch64-darwin with exactly that error when the sandbox is enabled. I found this locally in an unrelated setting and disabling the sandbox fixed it.

So is there any way to fix this for the package? I got that error from OFBorg. I would assume that the Hydra would have the same error when building the package for Darwin.

[purcell]

I didn't figure out what the fix might be, sorry, and didn't keep the error around long enough to file a primary bug against the zig derivation.

[wr7]

It seems the same issue was happening to zls. Going off of the pull request there (#290196), I've likely fixed the issue.

[wr7]

Zig 12 was recently released, but it makes sense to still use Zig 11 because using Zig 12 requires more patching than Zig 11.

[wr7]

Upstream now compiles with Zig 12 (nolanderc/glsl_analyzer#56). I've just updated the package to use that instead of my Zig 11 patch.

I also rebased.

[Aleksanaa]

Could we add something like

postPatch = ''
  substituteInPlace build.zig \
    --replace-fail 'b.run(&.{ "git", "describe", "--tags", "--always" })' '"${src.rev}"'
'';

To replace https://github.com/nolanderc/glsl_analyzer/blob/da890897ef5c4b1e6328cd614ed1808f00a0d351/build.zig#L100

[Aleksanaa]

leaveDotGit is potentially not deterministic so we'd better avoid it

[wr7]

leaveDotGit is potentially not deterministic so we'd better avoid it

Good to know. I've just applied your suggestion, and glsl_analyzer --version still works.

Thanks

[wr7]

I also realized that the commit description was no-longer accurate. I just removed it.

[wr7]

A new version was just released. It makes sense to just use that instead.

[pluiedev]

Result of nixpkgs-review pr 295076 run on x86_64-linux 1

1 package built:

• glsl_analyzer