Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.11] vesktop: update tsx dependency to ^4.6.1 #295540

Merged
merged 1 commit into from
Mar 22, 2024
Merged

[23.11] vesktop: update tsx dependency to ^4.6.1 #295540

merged 1 commit into from
Mar 22, 2024

Conversation

pluiedev
Copy link
Contributor

Description of changes

Fixes the build failure caused by outdated versions of the tsx library on Node 18.19+ (privatenumber/tsx#421).

Fixes #293083

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pluiedev
Copy link
Contributor Author

Oops, forgot to disable Alejandra while working on nixpkgs... xD

@pluiedev pluiedev force-pushed the fix/293083 branch 2 times, most recently from 5ee97c1 to 824337b Compare March 13, 2024 08:16
@pluiedev pluiedev changed the base branch from nixos-23.11 to release-23.11 March 13, 2024 08:17
@ofborg ofborg bot requested review from vgskye, getchoo and Scrumplex March 13, 2024 08:40
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Mar 13, 2024
getchoo
getchoo approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 295540 run on aarch64-linux 1

1 package built:
  • vesktop

@getchoo getchoo added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Mar 13, 2024
@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 295540 run on x86_64-linux 1

1 package built:
  • vesktop

@pluiedev
[23.11] vesktop: update tsx dependency to ^4.6.1
56660ef 
Fixes the build failure caused by outdated versions of the tsx library
on Node 18.19+ (privatenumber/tsx#421).

Fixes NixOS#293083
@pluiedev pluiedev requested review from leona-ya and Scrumplex March 17, 2024 22:59
@ofborg ofborg bot requested a review from getchoo March 18, 2024 00:47
leona-ya
leona-ya approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@leona-ya leona-ya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not happy with this as we require that hydra has the source cached, but okay for me as it's an improvement to before

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Mar 19, 2024
@leona-ya leona-ya merged commit 3eabdd3 into NixOS:release-23.11 Mar 22, 2024
18 checks passed
@Letgamer Letgamer mentioned this pull request Mar 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leona-ya leona-ya leona-ya approved these changes

@vgskye vgskye Awaiting requested review from vgskye

@Scrumplex Scrumplex Awaiting requested review from Scrumplex

@getchoo getchoo Awaiting requested review from getchoo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pluiedev @Scrumplex @leona-ya @getchoo @wegank