Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dafny packaging #300009

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Improve dafny packaging #300009

merged 1 commit into from
Dec 21, 2024

Conversation

layus
Copy link
Member

@layus layus commented Mar 29, 2024

  • dafny: add basic test for auto-updates
  • dafny: move to pkgs/by-name

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 29, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 4, 2024
@PetarKirov
Copy link

@layus can you please rebase your PR?

@layus layus force-pushed the dafny-tests branch 3 times, most recently from 8a1d8ec to 449f48f Compare December 2, 2024 09:50
@layus
Copy link
Member Author

layus commented Dec 2, 2024

@PetarKirov Thanks for reviewing this one. I have updated it and would appreciate if you could review it again and eventually merge it.

@layus layus mentioned this pull request Dec 2, 2024
13 tasks
@corngood corngood self-requested a review December 2, 2024 15:58
@corngood corngood removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 2, 2024
@corngood
Copy link
Contributor

corngood commented Dec 2, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 300009


x86_64-linux

@corngood
Copy link
Contributor

corngood commented Dec 2, 2024

This PR is missing the boilerplate in the top comment, but I ran the tests locally and they passed.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 2, 2024
@FliegendeWurst FliegendeWurst merged commit d555634 into NixOS:master Dec 21, 2024
18 of 20 checks passed
@corngood corngood added the backport release-24.11 Backport PR automatically label Dec 22, 2024
@nix-backports
Copy link

nix-backports bot commented Dec 22, 2024

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants