steamtinkerlaunch: 12.12 -> 12.12-unstable-2024-05-03 #305277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aleksanaa
reviewed
Apr 19, 2024
ofborg
bot
added
10.rebuild-darwin: 0
surfaceflinger
force-pushed
the
steamtinkerlaunch-unstable
branch
2 times, most recently
from
f778921 to
fa4c243
Compare
surfaceflinger
changed the title
Aleksanaa
approved these changes
Apr 20, 2024
surfaceflinger
force-pushed
the
steamtinkerlaunch-unstable
branch
2 times, most recently
from
d967f52 to
d702927
Compare
surfaceflinger
force-pushed
the
steamtinkerlaunch-unstable
branch
from
d702927 to
67decba
Compare
surfaceflinger
force-pushed
the
steamtinkerlaunch-unstable
branch
from
67decba to
6496a33
Compare
surfaceflinger
changed the title
|
Could you check if it fixes #309510? |
@Aleksanaa it doesn't. steamtinkerlaunch requires FHS environment to function properly so eg. in Steam. |
Aleksanaa
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Upstream didn't tag a release for some time and 12.12 doesn't have a workaround for running MO2, as the latest version is broken on wine.
Also worth noting that upstream actually recommends running the latest git commit instead of releases. -> sonic2kk/steamtinkerlaunch#1018 (comment)
so yeah, let's just switch to the latest commit. Tested it with Cyberpunk 2077 from Steam and it seems to be working fine, including MO2.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.