zinit: Fixes missing man pages #313045
Merged
zinit: Fixes missing man pages #313045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
ofborg
bot
added
10.rebuild-darwin: 0
Aleksanaa
reviewed
May 24, 2024
pkgs/shells/zsh/zinit/default.nix
Outdated
| @@ -24,6 +24,9 @@ stdenvNoCC.mkDerivation rec { | |||
| install -m0644 zinit{,-side,-install,-autoload}.zsh "$outdir" | |||
| install -m0755 share/git-process-output.zsh "$outdir" | |||
|
|
|||
| mkdir "$outdir/doc" | |||
| install -m0644 doc/zinit.1 "$outdir/doc/zinit.1" | |||
There was a problem hiding this comment.
Use installManpage in installShellFiles (add it to nativeBuildInputs).
Suggested change
| install -m0644 doc/zinit.1 "$outdir/doc/zinit.1" | |
| installManpage doc/zinit.1 |
There was a problem hiding this comment.
I had to update it to installManPage docs but this is done :)
connorgmeehan
force-pushed
the
fix/zinit-missing-docs
branch
from
66264dd to
5750140
Compare
connorgmeehan
force-pushed
the
fix/zinit-missing-docs
branch
from
5750140 to
651e55c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Copies the zinit docs to the output of the derivation to fix error when zinit initialises.
Zinit tries to copy the docs into the man pages, because these files aren't copied out to the ouput it errors. This causes an ugly error log when initialising zsh and can interfere with some nix-shell/zsh integration plugins.
Things done
nix.conf? (See Nix manual)sandbox = relaxed(default aarch64-darwin config?)sandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.