Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: fix buildInputs attribute typos #315204

Merged
merged 13 commits into from
Sep 13, 2024
Merged

treewide: fix buildInputs attribute typos #315204

merged 13 commits into from
Sep 13, 2024

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented May 27, 2024 •
edited
Loading

Description of changes

a misstyped rg led me to discover a bunch of these

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 8.has: documentation This PR adds or changes documentation labels May 27, 2024
@pbsds pbsds force-pushed the fix-attr-typos branch from 5fa7dcd to 8b57566 Compare May 27, 2024 23:06
@github-actions github-actions bot removed the 8.has: documentation This PR adds or changes documentation label May 27, 2024
@pbsds pbsds force-pushed the fix-attr-typos branch from 8b57566 to fe5f129 Compare May 27, 2024 23:09
@pbsds pbsds changed the base branch from master to staging May 27, 2024 23:09
@pbsds pbsds marked this pull request as ready for review May 27, 2024 23:18
@pbsds pbsds marked this pull request as draft June 6, 2024 21:35
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 4, 2024
@pbsds pbsds removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 12, 2024
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: erlang 6.topic: vscode labels Sep 12, 2024
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: erlang labels Sep 12, 2024
@pbsds pbsds marked this pull request as ready for review September 12, 2024 21:19
@pbsds pbsds requested a review from philiptaron as a code owner September 12, 2024 21:19
@pbsds
Copy link
Member Author

pbsds commented Sep 12, 2024

All of these build on x86_64-linux:

jackline
python311Packages.django-pwa
python311Packages.ipyniivue
python311Packages.openapi3
python311Packages.pycodestyle
python311Packages.pyogg
python311Packages.summarytools
python311Packages.symengine
python311Packages.trimesh
raspa-data
tezos-rust-libs

@Aleksanaa
Copy link
Member

(Why's there no naiveBuildInputs 😅)

@Aleksanaa Aleksanaa merged commit eaa7682 into NixOS:staging Sep 13, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philiptaron philiptaron philiptaron approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pbsds @Aleksanaa @philiptaron @wegank