Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkmanager: 1.46.0 → 1.48.0 #316417

Merged
merged 4 commits into from
Jun 8, 2024
Merged

networkmanager: 1.46.0 → 1.48.0 #316417

merged 4 commits into from
Jun 8, 2024

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Jun 1, 2024

Description of changes

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/1.48.0/NEWS?ref_type=tags
https://gitlab.gnome.org/GNOME/NetworkManager/-/compare/1.46.0...1.48.0

Fixes: #227788

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from obadz and domenkozar June 1, 2024 13:47
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Jun 1, 2024
@jtojnar jtojnar changed the base branch from staging to master June 1, 2024 15:15
@jtojnar
Copy link
Member Author

jtojnar commented Jun 1, 2024

Not including openvpn bump since it misses a tarball and there is an issue in Plasma with it.

Copy link
Contributor

@uninsane uninsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deployed to a variety of machines, covering the following scenarios:

  • ethernet + wifi desktop
  • wifi-only laptop
  • wifi + cellular modem (pinephone)
  • ethernet-only headless server

my relevant networking config is

systemd.network.enable = true;
networking.useNetworkd = true;
networking.networkmanager.enable = true;

the server uses networking.networkmanager.settings.main.dns = "systemd-resolved", while the others set that to "none" and manage their own DNS with custom NetworkManager-dispatcher scripts. each host also has various wireguard tunnels configured via systemd.network -- not NetworkManager's responsibility, rather good to see it's not interfering with them :)

i mention all that because there are a lot of interactions in this area. i didn't test any desktop interactions beyond sway + nmcli + firefox/epiphany, but i wouldn't be concerned there so long as everything compiles.

also, if you'd like to test NM next time without having to recompile everything take a look at this PR :)

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 4, 2024
@jtojnar jtojnar merged commit 782426c into NixOS:master Jun 8, 2024
27 checks passed
@jtojnar jtojnar deleted the nm branch June 8, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants