{influxdb, influxdb2}: update to fix build on Rust 1.78 #319969
Conversation
|
Result of 2 packages built:
|
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
|
Result of 2 packages built:
|
magneticflux-
force-pushed
the
influxdb2-update
branch
from
653fff2 to
5870e17
Compare
|
I also included the patch for Result of 3 packages built:
|
magneticflux-
changed the title
magneticflux-
force-pushed
the
influxdb2-update
branch
from
5870e17 to
624ff35
Compare
| --- a/flux/src/lib.rs | ||
| +++ b/flux/src/lib.rs | ||
| @@ -1,5 +1,3 @@ | ||
| -#![cfg_attr(feature = "strict", deny(warnings, missing_docs))] |
There was a problem hiding this comment.
Side question: should/Could we perhaps use --cap-lints warn by default for rust crates in nixpkgs?
There was a problem hiding this comment.
That seems like a good idea, would it go in NIX_RUSTFLAGS somewhere?
|
@ofborg build scrutiny nixosTests.scrutiny |
|
btw, CI indicates that libflux fails to build on aarch64 |
New patch addresses issues with Rust 1.78 until `influxdb2` updates `flux >= v0.195.0`. Removes `no-deny-warnings.patch` and previous Rust version patch as they are not needed anymore. Co-authored-by: éclairevoyant <[email protected]>
New patch addresses issues with Rust 1.78 until `influxdb` updates `flux >= v0.195.0`.
An inadvertent reliance on `char` being signed crept into `libflux`; this patch specifies a signed 8-bit type for the literal and then explicitly casts to the appropriate platform `c_char` type.
magneticflux-
force-pushed
the
influxdb2-update
branch
from
624ff35 to
d7aecd3
Compare
Already on it 😆 influxdata/flux#5495 |
|
@ofborg build scrutiny nixosTests.scrutiny |
This comment was marked as resolved.
This comment was marked as resolved.
|
building tests requires building the package, which requires one of:
I personally use binfmt for aarch64-linux in rare cases, but generally, and certainly for darwin, I let borgo do the work |
This comment was marked as resolved.
This comment was marked as resolved.
|
If you used Emulated compilation would be something like |
This comment was marked as resolved.
This comment was marked as resolved.
This also fixes a new build failure after Rust was updated.
New patch addresses issues with Rust 1.78 until
influxdb2updatesflux >= v0.195.0. Removesno-deny-warnings.patchand previous Rust version patch as they are not needed anymore.Fixes #319973
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.