Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inav-configurator -> inav-configurator5 #320054

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ilya-epifanov
Copy link
Contributor

Description of changes

With the versioning support in #320052 we can now support different major versions of INAV. There's no "default" version so we can't use the name inav-configurator without a version. Even the latest version doesn't make sense, since it's gonna break user setups.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ilya-epifanov ilya-epifanov changed the title renamed inav-configurator inoto inav-configurator5 renamed inav-configurator into inav-configurator5 Jun 15, 2024
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Jun 15, 2024
@ilya-epifanov ilya-epifanov force-pushed the inav-configurator5 branch 3 times, most recently from 9d31037 to 4bdb132 Compare June 15, 2024 17:35
@ilya-epifanov ilya-epifanov changed the title renamed inav-configurator into inav-configurator5 inav-configurator -> inav-configurator5 Jun 15, 2024
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Jun 15, 2024
@ofborg ofborg bot requested review from wucke13 and TilCreator June 15, 2024 18:11
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jun 15, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 4, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants