nixos/boot: add boot.tmp.useZram option #320917
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
luochen1990
force-pushed
the
wip-zram-as-tmp
branch
from
a3982b8 to
1574518
Compare
ofborg
bot
added
10.rebuild-darwin: 0
FliegendeWurst
requested changes
Dec 1, 2024
| example = "lzo-rle"; | ||
| description = '' | ||
| The compression algorithm to use for the zram device, | ||
| or leave unspecified to keep the kernel default. |
There was a problem hiding this comment.
The default is actually specified by us (not the kernel) as zstd.
Co-authored-by: Arne Keller <[email protected]>
FliegendeWurst
changed the title
| }; | ||
|
|
||
| zramSettings = { | ||
| zram-size = mkOption { |
There was a problem hiding this comment.
Suggested change
| zram-size = mkOption { | |
| zram-size = lib.mkOption { |
| ''; | ||
| }; | ||
|
|
||
| compression-algorithm = mkOption { |
There was a problem hiding this comment.
Suggested change
| compression-algorithm = mkOption { | |
| compression-algorithm = lib.mkOption { |
| ''; | ||
| }; | ||
|
|
||
| fs-type = mkOption { |
There was a problem hiding this comment.
Suggested change
| fs-type = mkOption { | |
| fs-type = lib.mkOption { |
| ''; | ||
| }; | ||
|
|
||
| options = mkOption { |
There was a problem hiding this comment.
Suggested change
| options = mkOption { | |
| options = lib.mkOption { |
|
|
||
| zramSettings = { | ||
| zram-size = mkOption { | ||
| type = types.str; |
There was a problem hiding this comment.
Suggested change
| type = types.str; | |
| type = lib.types.str; |
Same for other types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR provides an alternative option for the
boot.tmp.useTmpfssetting, allowing a zram device to be used directly as /tmp.In certain scenarios, this choice can be more effective than using zram as swap and waiting for tmpfs to trigger swap due to memory pressure. After all, the conditions for triggering swap are unrelated to the compression ratio of the content. In situations where it can be presupposed that the contents of the /tmp directory will have a higher compression ratio, the option provided by this PR will be an excellent solution.
Things done
Provide an option named
boot.tmp.useZram, and related options namedboot.tmp.zramSettings.*nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.