Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parlay: init at 0.6.0 #324684

Merged
merged 1 commit into from
Dec 1, 2024
Merged

parlay: init at 0.6.0 #324684

merged 1 commit into from
Dec 1, 2024

Conversation

kiike
Copy link
Member

@kiike kiike commented Jul 4, 2024

Things done

Created a package for parlay. Closes #324547. cc @kefniark (let me know if you're interested in maintaining this).

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kiike
Copy link
Member Author

kiike commented Jul 4, 2024

To test, it's enough to do

curl https://raw.githubusercontent.com/snyk/parlay/main/testing/sbom.cyclonedx.json | ./result/bin/parlay ecosystems enrich -

@kefniark
Copy link

kefniark commented Aug 21, 2024

@kefniark (let me know if you're interested in maintaining this).

Yes sure, I'm using the tool on regular basis so I can keep updating it.
For example, there was a version v0.5.1 few days ago https://github.com/snyk/parlay/releases

Is there anything we can do to get this PR reviewed and merged?
I feel that when the PR drift over page 50+, it's unlikely to get any attention anymore 😄

@kiike
Copy link
Member Author

kiike commented Sep 25, 2024

@kefniark (let me know if you're interested in maintaining this).

Yes sure, I'm using the tool on regular basis so I can keep updating it. For example, there was a version v0.5.1 few days ago https://github.com/snyk/parlay/releases

I added you to the maintainer list.

Is there anything we can do to get this PR reviewed and merged? I feel that when the PR drift over page 50+, it's unlikely to get any attention anymore 😄

You're right, it will probably slip under all radars, just like it did for me for over a month (sorry for the late reply 🙏).

Maybe it will be helpful if you can follow the checklist in https://discourse.nixos.org/t/prs-already-reviewed/2617 and then link the PR there.

@kiike kiike changed the title parlay: init at 0.4.0 parlay: init at 0.5.1 Sep 25, 2024
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Sep 25, 2024
pkgs/by-name/pa/parlay/package.nix Outdated Show resolved Hide resolved
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 3, 2024
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 5, 2024
Co-authored-by: Arne Keller <[email protected]>
@kiike kiike changed the title parlay: init at 0.5.1 parlay: init at 0.6.0 Nov 5, 2024
@kiike
Copy link
Member Author

kiike commented Nov 5, 2024

Took the chance to update the package too. The release happened during the NixCon and didn't notice it 😅

@FliegendeWurst FliegendeWurst added the needs_merger (old Marvin label, do not use) label Nov 19, 2024
@misuzu misuzu merged commit 45d1c6e into NixOS:master Dec 1, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people needs_merger (old Marvin label, do not use)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: parlay
5 participants