Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Pakcages.pid: remove nose dependency #327372

Closed

Conversation

mindstorms6
Copy link
Member

@mindstorms6 mindstorms6 commented Jul 15, 2024

Description of changes

pid package no longer needs nose as of this commit - remove nose dependency.

Addresses #326513.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy
Copy link
Member

emilazy commented Jul 15, 2024

That commit was merged after the latest upstream release, so we’ll have to vendor the patch for now, like in #326665. Please switch over to pyproject = true; build-system = [ setuptools ]; as well. I’m confused by the “No tests included” comment too… seems like there are tests? Would we still run them after this PR? We might need pytestCheckHook.

Also, typo: python3Pakcages.

@emilazy
Copy link
Member

emilazy commented Jul 31, 2024

Just checking in on if you’re planning to update this?

@mindstorms6
Copy link
Member Author

Yes sorry - been traveling. If it's blocking something - feel free to discard.

@mindstorms6 mindstorms6 force-pushed the python3packages-pid-remove-nose branch from d4de39b to c39f6cd Compare August 15, 2024 03:13
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: kernel The Linux kernel 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: vim 6.topic: lua 6.topic: vscode 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: k3s Kubernates distribution (https://k3s.io/) labels Aug 15, 2024
@mindstorms6 mindstorms6 marked this pull request as draft August 15, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: kernel The Linux kernel 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: vim 6.topic: vscode 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.