ulauncher: add pyasyncore for Python 3.12 compat #327753
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asyncore has been removed from Python 3.12. For applications that still
need it, the pyasyncore dependency can be explicitly added. So that's
what we'll do.
After nixpkgs updated to Python 3.12, I began getting the following
traceback when starting ulauncher.
Adding pyasyncore to propagatedBuildInputs solves this and ulauncher
functions normally with no errors logged.
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
../result/bin/
)