Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.http-ece: 1.2.0 -> 1.2.1; modernize #330771

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Jul 29, 2024

Description of changes

Part of #326513

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for sending a patch upstream!

pkgs/development/python-modules/http-ece/default.nix Outdated Show resolved Hide resolved
@pyrox0 pyrox0 marked this pull request as draft July 29, 2024 17:37
@pyrox0 pyrox0 force-pushed the denose/http-ece branch 2 times, most recently from af3472f to b1dd68e Compare July 31, 2024 16:41
@pyrox0 pyrox0 changed the title python312Packages.http-ece: drop nose dependency; modernize python312Packages.http-ece: 1.2.0 -> 1.2.1; modernize Jul 31, 2024
@pyrox0 pyrox0 marked this pull request as ready for review July 31, 2024 16:41
@pyrox0
Copy link
Member Author

pyrox0 commented Jul 31, 2024

Package has been updated, and previously mentioned PR has been merged. Updated appropriately, and ready for re-review now.

@pyrox0 pyrox0 requested a review from emilazy July 31, 2024 16:42
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Result of nixpkgs-review pr 330771 run on x86_64-linux 1

30 packages built:
  • home-assistant-component-tests.html5
  • home-assistant-component-tests.ring
  • mastodon-archive
  • mastodon-archive.dist
  • python311Packages.django-webpush
  • python311Packages.django-webpush.dist
  • python311Packages.firebase-messaging
  • python311Packages.firebase-messaging.dist
  • python311Packages.firebase-messaging.doc
  • python311Packages.http-ece
  • python311Packages.http-ece.dist
  • python311Packages.mastodon-py
  • python311Packages.mastodon-py.dist
  • python311Packages.push-receiver
  • python311Packages.push-receiver.dist
  • python311Packages.pywebpush
  • python311Packages.pywebpush.dist
  • python312Packages.django-webpush
  • python312Packages.django-webpush.dist
  • python312Packages.firebase-messaging
  • python312Packages.firebase-messaging.dist
  • python312Packages.firebase-messaging.doc
  • python312Packages.http-ece
  • python312Packages.http-ece.dist
  • python312Packages.mastodon-py
  • python312Packages.mastodon-py.dist
  • python312Packages.push-receiver
  • python312Packages.push-receiver.dist
  • python312Packages.pywebpush
  • python312Packages.pywebpush.dist

Result of nixpkgs-review pr 330771 run on aarch64-linux 1

30 packages built:
  • home-assistant-component-tests.html5
  • home-assistant-component-tests.ring
  • mastodon-archive
  • mastodon-archive.dist
  • python311Packages.django-webpush
  • python311Packages.django-webpush.dist
  • python311Packages.firebase-messaging
  • python311Packages.firebase-messaging.dist
  • python311Packages.firebase-messaging.doc
  • python311Packages.http-ece
  • python311Packages.http-ece.dist
  • python311Packages.mastodon-py
  • python311Packages.mastodon-py.dist
  • python311Packages.push-receiver
  • python311Packages.push-receiver.dist
  • python311Packages.pywebpush
  • python311Packages.pywebpush.dist
  • python312Packages.django-webpush
  • python312Packages.django-webpush.dist
  • python312Packages.firebase-messaging
  • python312Packages.firebase-messaging.dist
  • python312Packages.firebase-messaging.doc
  • python312Packages.http-ece
  • python312Packages.http-ece.dist
  • python312Packages.mastodon-py
  • python312Packages.mastodon-py.dist
  • python312Packages.push-receiver
  • python312Packages.push-receiver.dist
  • python312Packages.pywebpush
  • python312Packages.pywebpush.dist

pkgs/development/python-modules/http-ece/default.nix Outdated Show resolved Hide resolved
@pyrox0 pyrox0 force-pushed the denose/http-ece branch from b1dd68e to 0c54982 Compare July 31, 2024 21:07
@pbsbot
Copy link

pbsbot commented Aug 2, 2024

Result of nixpkgs-review pr 330771 run on x86_64-linux 1

30 packages built:
  • home-assistant-component-tests.html5
  • home-assistant-component-tests.ring
  • mastodon-archive
  • mastodon-archive.dist
  • python311Packages.django-webpush
  • python311Packages.django-webpush.dist
  • python311Packages.firebase-messaging
  • python311Packages.firebase-messaging.dist
  • python311Packages.firebase-messaging.doc
  • python311Packages.http-ece
  • python311Packages.http-ece.dist
  • python311Packages.mastodon-py
  • python311Packages.mastodon-py.dist
  • python311Packages.push-receiver
  • python311Packages.push-receiver.dist
  • python311Packages.pywebpush
  • python311Packages.pywebpush.dist
  • python312Packages.django-webpush
  • python312Packages.django-webpush.dist
  • python312Packages.firebase-messaging
  • python312Packages.firebase-messaging.dist
  • python312Packages.firebase-messaging.doc
  • python312Packages.http-ece
  • python312Packages.http-ece.dist
  • python312Packages.mastodon-py
  • python312Packages.mastodon-py.dist
  • python312Packages.push-receiver
  • python312Packages.push-receiver.dist
  • python312Packages.pywebpush
  • python312Packages.pywebpush.dist

@pbsds pbsds merged commit bc7a26d into NixOS:master Aug 2, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants