Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radio-cli: init at 2.3.1 #330817

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

luftmensch-luftmensch
Copy link
Contributor

Description of changes

Closes #330779

Release notes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Jul 29, 2024
pkgs/by-name/ra/radio-cli/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ra/radio-cli/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ra/radio-cli/package.nix Show resolved Hide resolved
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Jul 30, 2024
Copy link

@IldenH IldenH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why ofborg is failing, but looks good to me.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 4, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1904

@Pandapip1
Copy link
Contributor

@ofborg eval

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Aug 29, 2024
@marcusramberg
Copy link
Contributor

> Select a station to play: lofi
Playing lofi
Info: press 'q' to stop playing this station
thread 'main' panicked at src/main.rs:183:10:
Failed to execute mpv. Is it installed?: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Maybe add a dependency on mpv?

@luftmensch-luftmensch
Copy link
Contributor Author

luftmensch-luftmensch commented Sep 1, 2024

> Select a station to play: lofi
Playing lofi
Info: press 'q' to stop playing this station
thread 'main' panicked at src/main.rs:183:10:
Failed to execute mpv. Is it installed?: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Maybe add a dependency on mpv?

Gonna add it later

EDIT: @marcusramberg Done! It should be good to go now

@marcusramberg
Copy link
Contributor

Lgtm!

@marcusramberg marcusramberg merged commit 281bd58 into NixOS:master Sep 2, 2024
24 of 26 checks passed
@luftmensch-luftmensch luftmensch-luftmensch deleted the radio-cli_2.3.1 branch September 2, 2024 14:34
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Successfully created backport PR for release-24.05:

@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: radio-cli
7 participants