Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.python-{watcherclient,zaqarclient,zunclient}: init #331610

Merged
merged 3 commits into from
Sep 14, 2024
Merged

python311Packages.python-{watcherclient,zaqarclient,zunclient}: init #331610

merged 3 commits into from
Sep 14, 2024

Conversation

anthonyroussel
Copy link
Member

@anthonyroussel anthonyroussel commented Aug 1, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@anthonyroussel
Copy link
Member Author

anthonyroussel commented Aug 1, 2024 •
edited
Loading

@ofborg build python311Packages.python-watcherclient python311Packages.python-zaqarclient python311Packages.python-zunclient openstackclient-full

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 1, 2024
@ofborg ofborg bot requested a review from SuperSandro2000 August 1, 2024 22:47
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 1, 2024
@anthonyroussel anthonyroussel changed the title python311Packages.python-zaqarclient: init at 2.7.0 python311Packages.python-{watcherclient,zaqarclient,zunclient}: init Aug 4, 2024
@anthonyroussel
Copy link
Member Author

Result of nixpkgs-review pr 331610 run on x86_64-linux 1

8 packages built:
  • openstackclient-full
  • openstackclient-full.dist
  • watcherclient (python311Packages.python-watcherclient)
  • watcherclient.dist (python311Packages.python-watcherclient.dist)
  • python311Packages.python-zaqarclient
  • python311Packages.python-zaqarclient.dist
  • zunclient (python311Packages.python-zunclient)
  • zunclient.dist (python311Packages.python-zunclient.dist)

@anthonyroussel
Copy link
Member Author

Rebased against master and solved conflicts

@ofborg ofborg bot requested a review from Vinetos September 1, 2024 17:32
@anthonyroussel
Copy link
Member Author

Rebased against master branch and solved conflicts

@anthonyroussel
Copy link
Member Author

anthonyroussel commented Sep 13, 2024 •
edited
Loading

Oops, I pushed 2 commits by mistake (the ones for python311Packages.paste and python311Packages.pastedeploy).

I removed them

natsukium
natsukium approved these changes Sep 14, 2024
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@natsukium natsukium merged commit a3e08f4 into NixOS:master Sep 14, 2024
26 of 28 checks passed
@anthonyroussel anthonyroussel deleted the zaqarclient branch September 14, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium approved these changes

@Vinetos Vinetos Awaiting requested review from Vinetos

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anthonyroussel @SuperSandro2000 @Vinetos @natsukium