Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crystal-dock: init at 2.2 #332121

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

rafameou
Copy link
Member

@rafameou rafameou commented Aug 4, 2024

Description of changes

Homepage: https://github.com/dangvd/crystal-dock https://github.com/dangvd/crystal-dock/releases/tag/v2.2
Description: Crystal Dock is a cool dock (desktop panel) for Linux desktop, with the focus on attractive user interface, being simple and easy to use and customize, and cross-desktop support.
Note: This is the continuation of KSmoothDock (already in nixpkgs) by the same author, it supports wayland and is built on Qt6, currently it only supports Plasma 6 with Wayland. For some reason it doesn't run well on nix shell or nix run, but it will work fine if added in environment/home packages directly.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@rafameou rafameou force-pushed the add-crystal-dock branch 3 times, most recently from 40036b8 to 3e317ff Compare August 4, 2024 01:04
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 4, 2024
Copy link
Member

@afh afh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @rafameou, please find below a few suggestions for improvement 🙂

pkgs/by-name/cr/crystal-dock/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/cr/crystal-dock/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/cr/crystal-dock/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/cr/crystal-dock/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/cr/crystal-dock/package.nix Outdated Show resolved Hide resolved
@rafameou
Copy link
Member Author

rafameou commented Aug 5, 2024

Thanks for this, @rafameou, please find below a few suggestions for improvement 🙂

Hello, thanks for the suggestions! I have commited the changes.

@afh
Copy link
Member

afh commented Aug 5, 2024

Result of nixpkgs-review pr 332121 run on x86_64-linux 1

1 package built:
  • crystal-dock

Copy link
Member

@afh afh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for accepting the suggestions, @rafameou, much appreciated. From my point of view this looks good to be merged 👍

@afh afh added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 5, 2024
@thiagokokada thiagokokada merged commit 7bb83ee into NixOS:master Sep 2, 2024
27 of 28 checks passed
@rafameou rafameou deleted the add-crystal-dock branch September 3, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants