Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openthread-border-router: init at unstable-2024-10-18 #332296
base: master
Are you sure you want to change the base?
openthread-border-router: init at unstable-2024-10-18 #332296
Changes from all commits
47fb760
027ba7b
faa9a55
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: Hmm...it looks like the port number for the listening service is dynamic. I was confused and thought
49154
was hardcoded somewhere (note: there ARE other hardcoded ports in OpenThread code 🙈) but I think now it's simply from the "Dynamic and/or Private Ports (49152-65535)" range and shows up a lot in the OpenThread docs by coincidence.Frustratingly, from what I can tell, it's not clear if this is customizable after compile-time, which makes this tricky.
Original comment:
I think we also need an
openFirewall
option:I don't think it makes sense to have firewall options for REST/web.
In a VM/lab environment, the admin should add
allowedTCPPorts
forweb.listenPort
/rest.listenPort
themselves.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened a discussion about listener ports upstream: https://github.com/orgs/openthread/discussions/11093
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this should default to
127.0.0.1
. (Specifically, a localhost IP, and it appears that this is the convention throughout NixOS/nixpgs.)The REST API works fine on IPv4 even though Matter comms themselves use IPv6.
(Users can still pass
::1
if they want to listen on IPv6 localhost instead or::
as currently to listen on all.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, I think the web interface should default to a local IP, i.e.
127.0.0.1
.