freeshow: init at 1.2.1 #332658
freeshow: init at 1.2.1 #332658
Conversation
ofborg
bot
added
8.has: package (new)
pkgs/by-name/fr/freeshow/package.nix
Outdated
| hash = "sha256-RBI8IkxY6Xd36vCVDJy9sqpEisB/48hwQo+mg5XTCOs="; | ||
| }; | ||
| } | ||
| .${stdenv.system} or (throw "Unsupported system: ${stdenv.system}"); |
There was a problem hiding this comment.
Are we sure we can't build FreeShow from source? It seems to just be a Node.JS app.
There was a problem hiding this comment.
We probably could. but I don't see a remarkable benefit since upstream provided an appImage. It makes sure all the dependencies and libraries are hard coded into the package.Maybe the only advantage is that it would extend support to reach windows platforms.
There was a problem hiding this comment.
I'd rather reduce the amount of new pre-compiled packages on Nixpkgs, but this is a personal preference only, and the diff looks fine otherwise.
There was a problem hiding this comment.
I will try to make it a source based package and if the build succeeds I will update the PR.
ByteSudoer
force-pushed
the
init-freeshow
branch
from
498d93c to
fe42cd1
Compare
ByteSudoer
force-pushed
the
init-freeshow
branch
from
fe42cd1 to
fdffbb6
Compare
|
Any luck with this? |
ByteSudoer
force-pushed
the
init-freeshow
branch
from
fdffbb6 to
9e58c70
Compare
ByteSudoer
requested review from
eclairevoyant,
SigmaSquadron and
FliegendeWurst
This comment was marked as off-topic.
This comment was marked as off-topic.
ByteSudoer
force-pushed
the
init-freeshow
branch
from
9e58c70 to
220f0db
Compare
FliegendeWurst
added
the
12.approvals: 1
| hash = "sha256-RBI8IkxY6Xd36vCVDJy9sqpEisB/48hwQo+mg5XTCOs="; | ||
| }; | ||
| } | ||
| .${stdenv.hostPlatform.system} or (throw "Unsupported system: ${stdenv.system}"); |
There was a problem hiding this comment.
It won't evaluate for platforms absent from the list of supported platforms anyway
| .${stdenv.hostPlatform.system} or (throw "Unsupported system: ${stdenv.system}"); | |
| .${stdenv.hostPlatform.system}; |
There was a problem hiding this comment.
This is a very common pattern in nixpkgs. I would keep the throw.
There was a problem hiding this comment.
It's common, but not necessary. See #314224
| cp -a ${appimageContents}/usr/share/icons $out/share | ||
| install -Dm 444 ${appimageContents}/freeshow.desktop $out/share/applications | ||
| substituteInPlace $out/share/applications/freeshow.desktop \ | ||
| --replace-warn 'Exec=AppRun' 'Exec=freeshow' |
There was a problem hiding this comment.
| --replace-warn 'Exec=AppRun' 'Exec=freeshow' | |
| --replace-warn 'Exec=AppRun' 'Exec=freeshow' |
wegank
added
12.approvals: 2
There was a problem hiding this comment.
I maintain my original review; I'd rather not have more sourceProvenance = binaryNativeCode FOSS apps in Nixpkgs. I'm sure this could become a source build. The Nixpkgs manual has a pretty good section on JS apps, and there are a few examples of similar GUI packages in the tree.
Once more, while I'm confident that you can turn this into a source build, if it proves too difficult or overly time-consuming, then feel free to reply as such and disregard this comment.
wegank
removed
the
12.approvals: 2
Description of changes
Project description
FreeShow is a free and open-source presentation program that makes it easy to show text on a big screen. It supports stage display, remote control, media, and many other advanced features. It is open-sourced meaning anyone can contribute.
FreeShow exists because the creator found that other simular programs was either expensive or complex to use. He wanted to create a program that was easy to use and affordable for everyone, from small churches to large venues. FreeShow is now used by people all over the world.
Metadata
Closes #332304
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.