Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liana: 5.0 -> 6.0 #333059

Merged
merged 1 commit into from
Aug 13, 2024
Merged

liana: 5.0 -> 6.0 #333059

merged 1 commit into from
Aug 13, 2024

Conversation

dunxen
Copy link
Contributor

@dunxen dunxen commented Aug 7, 2024

Description of changes

Diff: wizardsardine/liana@v5.0...v6.0

This update will also address the package failing to build with Rust 1.80 (#332957).

Still broken on aarch64-linux which is unrelated to the Rust 1.80 issue.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@dunxen dunxen marked this pull request as draft August 7, 2024 19:10
@dunxen
Copy link
Contributor Author

dunxen commented Aug 7, 2024

Hmm. I've found a few issues I'm going to address first.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 7, 2024
@dunxen
Copy link
Contributor Author

dunxen commented Aug 12, 2024

Needed some new runtime libs

@dunxen dunxen marked this pull request as ready for review August 12, 2024 20:59
@alyssais alyssais merged commit 3f116e6 into NixOS:master Aug 13, 2024
28 of 29 checks passed
@dunxen dunxen deleted the update-liana-v6 branch August 14, 2024 05:34
@dunxen dunxen mentioned this pull request Aug 14, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants