-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autotier: init at 1.2.0, lib45d: init at 0.3.6, nixos/autotierfs: init module #335846
Conversation
162a889
to
236d67e
Compare
2acfe23
to
9a6d3f3
Compare
e172a5e
to
8b46c26
Compare
368c965
to
0d07c58
Compare
Tested after applying changes and it is working locally on one disk on my pc. Late February I am building a new nas so will be able to test it in prod at that point across hard drives+ssds. This MR is ready for testing now, the pr can be applied to your local nixpkgs via
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM. Feel free to ping in a couple days if there are no other reviews -- or whenever you have finished testing ;)
Edit: This should also go into the new modules section of the release notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this get a mention in the release notes?
Description of changes
lib45d is a direct dependency of autotier and nothing else afaik so merging them in one pr is appropriate imo. The new module lets you enable/configure autotier.
The option is as simple as possible:.
The setting option expects an attrset of INIs, with each attr being one autotier tier.
Such as:
etc. Configurations are put int
/etc/autotier/
for easy access for use with theautotier
command. Adding your user to theautotier
group lets you use it without root.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.