Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunderbird-bin-unwrapped: 115.13.0 → 128.1.0esr #336105

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

vincentbernat
Copy link
Member

Description of changes

Thunderbird now has an ESR release. Therefore, update to this one (same version as the non-binary version). Also tweak the update script to accept a version prefix and follow ESR this way.

Also see some comments in #307602.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 20, 2024
@taku0
Copy link
Contributor

taku0 commented Aug 24, 2024

Running thunderbird results in Segmentation fault.

@vincentbernat vincentbernat force-pushed the feature/thunderbird-esr branch from a50caca to cdd6b34 Compare August 24, 2024 07:25
@vincentbernat
Copy link
Member Author

Running thunderbird results in Segmentation fault.

It works for me, but I am running it on top of Debian. I don't have yet a desktop with NixOS to test.

Thunderbird now has an ESR release. Therefore, update to this one (same
version as the non-binary version). Also tweak the update script to
accept a version prefix and follow ESR this way.
@vincentbernat vincentbernat force-pushed the feature/thunderbird-esr branch from cdd6b34 to 76c3e5c Compare August 24, 2024 07:57
@taku0
Copy link
Contributor

taku0 commented Aug 24, 2024

We should rewrite thunderbird-bin package to use autoPatchelfHook like firefox-bin package. Will you rewrite it? If not, I will.

@vincentbernat
Copy link
Member Author

Please do, I won't be able to test the result.

@taku0
Copy link
Contributor

taku0 commented Aug 25, 2024

Added a commit to migrate to autoPatchelfHook. Codes are largely borrowed from firefox-bin. This works on my NixOS machine.

@lovesegfault, could you review this?

@taku0 taku0 merged commit 9a7a4e2 into NixOS:master Sep 16, 2024
21 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.05:

@vincentbernat
Copy link
Member Author

Any reason we don't get 128.2.3esr PR automatically? Dunno where to look for a failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants