-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.scikit-network: init at 0.33.0 #336136
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the three commits 7988c47faf346d440d74f73c440d20624c812f3b, 706dc4f8e4542bac75f9de94ce7be6a16595adb0 and afd3fc24dc071af6586aa82f3d7a3c19a160b90f should be squashed together
- package needs an entry in
pkgs/top-level/python-packages.nix
- the title of the commit introducing the package should be
python3Packages.scikit-network: init at 0.33.0
@ofborg eval |
afd3fc2
to
73f9752
Compare
e909864
to
706e860
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, while building the package is fine, afterwards trying to import it I get an error:
Edit 27-09-2024: This was a fsck-up from my site; apparently python3.11
inside the nixpkgs-review sets the search path wrong for the modules. Now verified the import with both 3.11 and 3.12, both work totally fine!
Thus: LGTM!
706e860
to
4ddaa30
Compare
4ddaa30
to
df2e781
Compare
Description of changes
Added python package
scikit-network
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.