tuxedo-keyboard: fix compilation for kernel 6.10 and 6.11

[Keksgesicht]

Description of changes

It seems like the tuxedo-keyboard has moved to GitLab a little time ago. Thus, I changed the source git the new GitLab URL and updated the version number. This also fixes a bug when compiling with Kernel 6.10.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[K900]

Please change the commit message format to fit the guidelines in CONTRIBUTING.md

[K900]

Also, it may be worth renaming the package to fit its presumably now extended scope?

[Keksgesicht]

I also renamed the related config options to the new scope of the tuxedo driver. I hope this is ok.

[Keksgesicht]

There are already commit in the new upstream repo to fix compile errors with kernel 6.11. Thus, I will most likely provide a follow up pull request the coming days to update this driver to version 4.6.3.

[MinerSebas]

As you renamed the package here, could you add an alias to block at line 608, in-case someone didn't use the module.
Something like this:

tuxedo-keyboard = self.tuxedo-drivers;

[MinerSebas]

Still works on my Pulse Gen 1.

[Keksgesicht]

Now it also runs with kernel 6.11 on my Aura 15 Gen1.

[Keksgesicht]

@blanky0230 What do you think? As you are the maintainer could you review my changes please so it's clear to committers in what state this is?

[blanky0230]

Hate to nitpick catching up with reviews this late but: Since the manufacturer's repo is named "tuxedo-drivers" (plural), I think the corresponding linuxPackage and nixosModule in nixpkgs should share the same name in order to minimize the possibility for mix-ups and user's confusion in the future.

Other than that this PR is looking good to me 👍

[Keksgesicht]

@chmanie looks fine so far. You could test if the Fn keys control the brightness. If your DM/WM does not comply with that and your InfintyBook has also only a "white" keyboard backlight, you maybe have to do this instead: #336633 (comment)

For the failed temperature reading I am not sure whether this driver or a generic one for the Intel or AMD platform provides this sensor. Try running sensors-detect of the lm-sensors package and look into /etc/sysconfig/lm_sensors afterwards. Then add them to boot.kernelModules and see whether this ERROR from tailord goes away.

[Keksgesicht]

So, I rebased and fixed a merge conflict because someone added some system76 things above of my changes in pkgs/top-level/linux-kernels.nix. I even updated the package to the newest upstream version.

Is there something else I have to do? How do I get the attention of a committer to merge this?

[xaverdh]

The Failed reading the current temperature error occurs on startup for me as well, and used to with the old module as well. I think it's race condition with the driver and not something we can fix.

[xaverdh]

cc @SuperSandro2000

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4779

[ClockGen]

@K900 can you please check this PR.

[WhiteBlackGoose]

@Keksgesicht I tried what you said (with the new commit):

    nixpkgs = {
      type = "github";
      owner = "NixOS";
      repo = "nixpkgs";
      ref = "master";
      rev = "fa957fa9d827c2bf471acdf00c89806cec47926b";
    };

Sadly I'm getting the same error:

error: builder for '/nix/store/ms8133zszndd33if81x0vv8y5d70i8y1-tuxedo-keyboard-6.11.5-3.2.14.drv' failed with exit code 2;
       last 10 log lines:
       > /build/source/./src/uniwill_keyboard.h:1259:19: error: initialization of 'void (*)(struct platform_device *)' from incompatible pointer type 'int (*)(struct platform_device *)' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wincompatible-pointer-types-Werror=incompatible-pointer-types8;;]
       >  1259 |         .remove = uniwill_keyboard_remove,
       >       |                   ^~~~~~~~~~~~~~~~~~~~~~~
       > /build/source/./src/uniwill_keyboard.h:1259:19: note: (near initialization for 'platform_driver_uniwill.<anonymous>.remove')

[WhiteBlackGoose]

setting it directly to your fork worked though:

    nixpkgs = {
      type = "github";
      owner = "Keksgesicht";
      repo = "nixpkgs";
      ref = "master";
      rev = "8972df5e5ace61612feec3d88b8d768b041dc664";
    };

[papanito]

so now that it's merged to master, how we can use it? Or better when will be in unstable?

[xaverdh]

so now that it's merged to master, how we can use it? Or better when will be in unstable?

The unstable channel just advanced a few hours ago, so it should be there already.

[xaverdh]

by the way thanks for merging this @SuperSandro2000 ❤️