flameshot: fix build on Darwin #336647
Merged
flameshot: fix build on Darwin #336647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smancill
force-pushed
the
flameshot-fix-darwin
branch
from
0c63444 to
092dc76
Compare
smancill
force-pushed
the
flameshot-fix-darwin
branch
from
092dc76 to
215e51a
Compare
But it is. I don't understand. It's already two commits, one to reformat and the other applying the Darwin fixes 😕 |
|
There's other changes in the reformat commit, which is why I asked. We can't exclude the commit as-is because it's changing other parts of the expression. |
- Only enable Wayland options on Linux - Disable update checker - Add support to build with the monochrome icon
smancill
force-pushed
the
flameshot-fix-darwin
branch
from
215e51a to
0174d4a
Compare
|
Got it. It should be OK now. |
UnsolvedCypher
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix build on Darwin.
Closes #334739.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.