assetripper: init at 1.1.3 #337548
assetripper: init at 1.1.3 #337548
Conversation
ofborg
bot
added
8.has: package (new)
|
Works for me. Thank you. |
This comment was marked as outdated.
This comment was marked as outdated.
UlyssesZh
added
the
9.needs: upstream fix
| src = fetchFromGitHub { | ||
| owner = "AssetRipper"; | ||
| repo = "AssetRipper"; | ||
| rev = "refs/tags/${finalAttrs.version}"; |
There was a problem hiding this comment.
Please rebase on master branch and do this:
| rev = "refs/tags/${finalAttrs.version}"; | |
| tag = finalAttrs.version; |
See #355973.
There was a problem hiding this comment.
I've tried rebasing locally and it doesn't build. I think something the fault is in Nixpkgs, but I haven't finished bisecting.
There was a problem hiding this comment.
Could you share the build error you are receiving? If it is related to missing lib deps in two of the nuget precompiled libraries, then I have overcome that by including stdenv.cc.cc.lib in the buildInputs as a temporary fix. Would be interested in finding the breaking commit.
There was a problem hiding this comment.
That was it, yeah.
searching for dependencies of /nix/store/y5y38bj32dd71ki3q1k0slnm2jals223-AssetRipper-1.1.3/lib/AssetRipper/libTexture2DDecoderNative.so
libstdc++.so.6 -> not found!
libgcc_s.so.1 -> not found!
auto-patchelf: 2 dependencies could not be satisfied
error: auto-patchelf could not satisfy dependency libstdc++.so.6 wanted by /nix/store/y5y38bj32dd71ki3q1k0slnm2jals223-AssetRipper-1.1.3/lib/AssetRipper/libTexture2DDecoderNative.so
error: auto-patchelf could not satisfy dependency libgcc_s.so.1 wanted by /nix/store/y5y38bj32dd71ki3q1k0slnm2jals223-AssetRipper-1.1.3/lib/AssetRipper/libTexture2DDecoderNative.so
auto-patchelf failed to find all the required dependencies.
Add the missing dependencies to --libs or use `--ignore-missing="foo.so.1 bar.so etc.so"`.
Culprit being 687371a (not sure how removing Python from propagated deps means removing libstdc++ but there you go).
|
|
||
| buildDotnetModule (finalAttrs: { | ||
| pname = "AssetRipper"; | ||
| version = "1.1.3"; |
There was a problem hiding this comment.
AssetRipper has new releases:
| version = "1.1.3"; | |
| version = "1.1.7"; |
There was a problem hiding this comment.
Need to bump to .NET 9 for this by the way.
There was a problem hiding this comment.
Good question. The passthru fetch-deps fails for me too. Looking through my shell history, I dropped into a dotnet sdk nix-shell within the project's source and ran approximately the following:
dotnet restore --packages out
nuget-to-nix out > deps.nixThere was a problem hiding this comment.
Note that in comments. Failing to fetch deps automatically would mean that it cannot be updated properly with an update script, and people have to manually handle that, and they need to know how to do that manually by reading the relevant comments.
I am suspecting this be some bug of nuget-to-nix, but considering that currently there is work going on to retire nuget-to-nix (#362278), it may not worth digging into it. However, it would still be good if you can look into this.
There was a problem hiding this comment.
I got 1.1.7 1.1.8 building. YoshiRulz@2dc01fc
|
Make sure your commit complies with the relevant conventions. To elaborate, the package name should be all lower-case, and remove the space between "Asset Ripper" in your commit message. |
|
Took the following steps and squashed.
|
|
Above push does the following: Updated meta.mainProgram to reflect symlink. |
Description of changes
AssetRipper is a tool for extracting assets from Unity serialized files (CAB-*, *.assets, *.sharedAssets, etc.) and asset bundles (*.unity3d, *.bundle, etc.) and converting them into the native Unity engine format.
https://github.com/AssetRipper/AssetRipper
The patch is is a temporary measure until AssetRipper/AssetRipper#1414 is resolved.
Closes #297634
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.