Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limine: 7.9.1 -> 8.0.9 #338953

Closed
wants to merge 2 commits into from
Closed

limine: 7.9.1 -> 8.0.9 #338953

wants to merge 2 commits into from

Conversation

lzcunt
Copy link
Contributor

@lzcunt lzcunt commented Sep 2, 2024 •
edited
Loading

Description of changes

The package is updated to limine 8.0.9 (changelog) and support for disabling targets has been added (as before, all targets are built by default). I've also added myself as a maintainer.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Sep 2, 2024
@ofborg ofborg bot requested a review from 48cf September 2, 2024 07:52
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 2, 2024
@lzcunt lzcunt force-pushed the limine/bump-version branch from fb4e09d to 781d897 Compare September 4, 2024 18:36
@lzcunt lzcunt changed the title limine: 7.9.1 -> 8.0.7 limine: 7.9.1 -> 8.0.9 Sep 4, 2024
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 6, 2024
@surfaceflinger surfaceflinger mentioned this pull request Sep 10, 2024
Merged
13 tasks
@lzcunt
Copy link
Contributor Author

lzcunt commented Sep 12, 2024

Closed in favor of #341087

@lzcunt lzcunt closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@48cf 48cf 48cf approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lzcunt @48cf @wegank