Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single-file-cli: remove chromedriver from nativeCheckInputs #339062

Merged

Conversation

icewind1991
Copy link
Contributor

Description of changes

chromedriver is the only thing stopping this from building on aarch64 linux and isn't required to run the test.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

chromedriver is the only thing stopping this from building on aarch64 linux and isn't required to run the test
@n8henrie
Copy link
Contributor

n8henrie commented Sep 4, 2024

Result of nixpkgs-review pr 339062 run on aarch64-linux 1

1 package built:
  • single-file-cli

@n8henrie
Copy link
Contributor

n8henrie commented Sep 4, 2024

Sweet, looks good to me! I think I had chromedriver because I was trying to get tests working on aarch64-darwin (unfortunately none of the major browsers build on darwin, though chromedriver does).

Unfortunately sandbox issues with local networking got in the way, so we limited to testing to Linux anyway.

Thanks!

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 4, 2024
@NickCao NickCao merged commit ca5835d into NixOS:master Sep 12, 2024
31 of 32 checks passed
@icewind1991 icewind1991 deleted the single-file-cli-remove-chromedriver branch September 13, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants