Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.lightning-utilities: 0.11.6 -> 0.11.7 #339111

Merged
merged 3 commits into from
Sep 5, 2024
Merged

python312Packages.lightning-utilities: 0.11.6 -> 0.11.7 #339111

merged 3 commits into from
Sep 5, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Sep 2, 2024 •
edited
Loading

Description of changes

Changelog: https://github.com/Lightning-AI/utilities/releases/tag/v0.11.7

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage GaetanLepage marked this pull request as draft September 2, 2024 21:34
@GaetanLepage GaetanLepage marked this pull request as ready for review September 2, 2024 22:04
@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 339111 run on x86_64-linux 1

8 packages marked as broken and skipped:
  • piper-train
  • piper-train.dist
  • python311Packages.elegy
  • python311Packages.elegy.dist
  • python311Packages.treex
  • python311Packages.treex.dist
  • python312Packages.rising
  • python312Packages.rising.dist
24 packages built:
  • python311Packages.finetuning-scheduler
  • python311Packages.finetuning-scheduler.dist
  • python311Packages.lightning-utilities
  • python311Packages.lightning-utilities.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python311Packages.pytorch-lightning
  • python311Packages.pytorch-lightning.dist
  • python311Packages.rising
  • python311Packages.rising.dist
  • python311Packages.torchmetrics
  • python311Packages.torchmetrics.dist
  • python312Packages.finetuning-scheduler
  • python312Packages.finetuning-scheduler.dist
  • python312Packages.lightning-utilities
  • python312Packages.lightning-utilities.dist
  • python312Packages.pyannote-audio
  • python312Packages.pyannote-audio.dist
  • python312Packages.pytorch-lightning
  • python312Packages.pytorch-lightning.dist
  • python312Packages.torchmetrics
  • python312Packages.torchmetrics.dist
  • whisper-ctranslate2
  • whisper-ctranslate2.dist

bcdarwin
bcdarwin approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 339111 run on aarch64-linux 1

4 packages marked as broken and skipped:
  • piper-train
  • piper-train.dist
  • python312Packages.rising
  • python312Packages.rising.dist
24 packages built:
  • python311Packages.finetuning-scheduler
  • python311Packages.finetuning-scheduler.dist
  • python311Packages.lightning-utilities
  • python311Packages.lightning-utilities.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python311Packages.pytorch-lightning
  • python311Packages.pytorch-lightning.dist
  • python311Packages.rising
  • python311Packages.rising.dist
  • python311Packages.torchmetrics
  • python311Packages.torchmetrics.dist
  • python312Packages.finetuning-scheduler
  • python312Packages.finetuning-scheduler.dist
  • python312Packages.lightning-utilities
  • python312Packages.lightning-utilities.dist
  • python312Packages.pyannote-audio
  • python312Packages.pyannote-audio.dist
  • python312Packages.pytorch-lightning
  • python312Packages.pytorch-lightning.dist
  • python312Packages.torchmetrics
  • python312Packages.torchmetrics.dist
  • whisper-ctranslate2
  • whisper-ctranslate2.dist

@ofborg ofborg bot requested a review from bcdarwin September 2, 2024 23:58
@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 339111 run on x86_64-darwin 1

14 packages marked as broken and skipped:
  • piper-train
  • piper-train.dist
  • python311Packages.finetuning-scheduler
  • python311Packages.finetuning-scheduler.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python312Packages.finetuning-scheduler
  • python312Packages.finetuning-scheduler.dist
  • python312Packages.pyannote-audio
  • python312Packages.pyannote-audio.dist
  • python312Packages.rising
  • python312Packages.rising.dist
  • whisper-ctranslate2
  • whisper-ctranslate2.dist
14 packages built:
  • python311Packages.lightning-utilities
  • python311Packages.lightning-utilities.dist
  • python311Packages.pytorch-lightning
  • python311Packages.pytorch-lightning.dist
  • python311Packages.rising
  • python311Packages.rising.dist
  • python311Packages.torchmetrics
  • python311Packages.torchmetrics.dist
  • python312Packages.lightning-utilities
  • python312Packages.lightning-utilities.dist
  • python312Packages.pytorch-lightning
  • python312Packages.pytorch-lightning.dist
  • python312Packages.torchmetrics
  • python312Packages.torchmetrics.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 339111 run on aarch64-darwin 1

18 packages marked as broken and skipped:
  • piper-train
  • piper-train.dist
  • python311Packages.elegy
  • python311Packages.elegy.dist
  • python311Packages.finetuning-scheduler
  • python311Packages.finetuning-scheduler.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python311Packages.treex
  • python311Packages.treex.dist
  • python312Packages.finetuning-scheduler
  • python312Packages.finetuning-scheduler.dist
  • python312Packages.pyannote-audio
  • python312Packages.pyannote-audio.dist
  • python312Packages.rising
  • python312Packages.rising.dist
  • whisper-ctranslate2
  • whisper-ctranslate2.dist
14 packages built:
  • python311Packages.lightning-utilities
  • python311Packages.lightning-utilities.dist
  • python311Packages.pytorch-lightning
  • python311Packages.pytorch-lightning.dist
  • python311Packages.rising
  • python311Packages.rising.dist
  • python311Packages.torchmetrics
  • python311Packages.torchmetrics.dist
  • python312Packages.lightning-utilities
  • python312Packages.lightning-utilities.dist
  • python312Packages.pytorch-lightning
  • python312Packages.pytorch-lightning.dist
  • python312Packages.torchmetrics
  • python312Packages.torchmetrics.dist

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 4, 2024
@adamcstephens adamcstephens merged commit da80a48 into NixOS:master Sep 5, 2024
38 of 39 checks passed
@GaetanLepage GaetanLepage deleted the lightning-utilities branch September 5, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium Awaiting requested review from natsukium

@bcdarwin bcdarwin Awaiting requested review from bcdarwin

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GaetanLepage @bcdarwin @adamcstephens @wegank