opencomposite-helper: drop #340334
Merged
opencomposite-helper: drop #340334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helper script made use of `VR_OVERRIDE` which causes issues with some applications/games. As detailed in 3rd-party documentation[0] the recommended way to setup OpenComposite is to configure `$XDG_CONFIG_HOME/openvr/openvrpaths.vrpath` instead. This is also documented on the NixOS Wiki[1]. [0]: https://monado.freedesktop.org/valve-index-setup.html#5-setting-up-opencomposite [1]: https://wiki.nixos.org/wiki/VR#OpenComposite Signed-off-by: Sefa Eyeoglu <[email protected]>
|
CC @Pandapip1 any objections? |
Pandapip1
approved these changes
Sep 7, 2024
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 0
Scrumplex
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This helper script made use of
VR_OVERRIDEwhich causes issues with some applications/games. As detailed in 3rd-party documentation[0] the recommended way to setup OpenComposite is to configure$XDG_CONFIG_HOME/openvr/openvrpaths.vrpathinstead.This is also documented on the NixOS Wiki[1].
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.