vimPlugins.leetcode-nvim: init at 2024-06-27

[nvimtor]

Description of changes

Adds the plugin leetcode.nvim.

Includes hard dependencies telescope-nvim and nui-nvim.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[linsui]

Close #274061

[PerchunPak]

LGTM! The order doesn't matter as it is broken anyway

Fixes #274061

CC @GaetanLepage

[nvimtor]

Also updated the SHA as it was incorrect; apologies. I double checked it with nurl and it should be the correct hash now.

[GaetanLepage]

I have made minor cosmetic changes.

[GaetanLepage]

Result of nixpkgs-review pr 340378 run on x86_64-linux 1

1 package failed to build:

• vimPlugins.leetcode-nvim

1 package built:

• vimPluginsUpdater

[GaetanLepage]

Looks like dependencies are not transitive: telescope-nvim has plenary-nvim as a dependency, but leetcode-nvim won't see it (despite it having telescope-nvim as a dependency).

cc @teto (I have been pinging you a lot lately, sorry for that)

[GaetanLepage]

Result of nixpkgs-review pr 340378 run on x86_64-linux 1

1 package failed to build:

• vimPlugins.leetcode-nvim

1 package built:

• vimPluginsUpdater

[GaetanLepage]

Result of nixpkgs-review pr 340378 run on x86_64-linux 1

1 package failed to build:

• vimPlugins.leetcode-nvim

1 package built:

• vimPluginsUpdater

[GaetanLepage]

Check whether the following module can be imported: leetcode
Error detected while processing pre-vimrc command line:
E518: Unknown option: /nix/store/9711k560h24xp38drsrdzjawfm3v6i2p-vimplugin-lua5.1-telescope.nvim-scm-1-unstable-2024-09-11
Entering Ex mode.  Type "visual" to go to Normal mode.

[GaetanLepage]

We need to fix the require check.

[PerchunPak]

Blocked by #342240 (tracker)

[teto]

Looks like dependencies are not transitive: telescope-nvim has plenary-nvim as a dependency, but leetcode-nvim won't see it (despite it having telescope-nvim as a dependency).

ha indeed. The neovimRequireCheckHook just adds the listed dependencies to RTP. a quickfix could be to add vimUtils.transitiveClosure dependencies to rtp instead. It still wont work for plugins that pull python provider/extra programs dependencies etc but could work for 90% plugins.
Ideally we would use the same utilities to generate the wrapped neovim and the tests. We are getting there :)

[PerchunPak]

ha indeed. The neovimRequireCheckHook just adds the listed dependencies to RTP. a quickfix could be to add vimUtils.transitiveClosure dependencies to rtp instead. It still wont work for plugins that pull python provider/extra programs dependencies etc but could work for 90% plugins. Ideally we would use the same utilities to generate the wrapped neovim and the tests. We are getting there :)

#342240 fixes it, no?

[teto]

#342240 fixes it, no?

I dont think so, it will just expand the derivation dependencies without the transitives ones, as mentioned by gaetan.

[PerchunPak]

git cherry-pick b858149 dc2ec23 && nix-build -A vimPlugins.leetcode-nvim builds succesful, so... it is fixed by #342240

[GaetanLepage]

git cherry-pick b858149 dc2ec23 && nix-build -A vimPlugins.leetcode-nvim builds succesful, so... it is fixed by #342240

@nvimtor can you go ahead and rebase this then please ?

[PerchunPak]

nvimtor can you go ahead and rebase this then please ?

No, because b858149 is #342240, which is currently in staging-next and not in master (https://nixpk.gs/pr-tracker.html?pr=342240)

EDIT: see also #343421

[GaetanLepage]

No, because b858149 is #342240, which is currently in staging-next and not in master (https://nixpk.gs/pr-tracker.html?pr=342240)

Oh right, I got tricked by the "merged" status.

[PerchunPak]

b858149 got to master, so this can be rebased and merged 🎉

[nvimtor]

@PerchunPak @GaetanLepage done; just to clarify, do we still need plenary.nvim to be listed as a dependency?

[nvimtor]

Ah, let me run nix fmt.

[GaetanLepage]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 340378

---

x86_64-linux

✅ 2 packages built:

• vimPlugins.leetcode-nvim
• vimPluginsUpdater

---

aarch64-linux

✅ 2 packages built:

• vimPlugins.leetcode-nvim
• vimPluginsUpdater

---

x86_64-darwin

✅ 2 packages built:

• vimPlugins.leetcode-nvim
• vimPluginsUpdater

---

aarch64-darwin

✅ 2 packages built:

• vimPlugins.leetcode-nvim
• vimPluginsUpdater

[GaetanLepage]

do we still need plenary.nvim to be listed as a dependency?

Can you try without it ?
The requireCheck should catch a failure if it would happen to not propagate from telescope.

[nvimtor]

@GaetanLepage Great, it does fail without plenary.nvim:

error: builder for '/nix/store/xl6s5s6ahy5ih6bw1cpnnznplrh31scc-vimplugin-leetcode.nvim-2024-06-27.drv' failed with exit code 1;
       last 30 log lines:
       > Executing vimCommandCheckHook
       > Running phase: neovimRequireCheckHook
       > Executing neovimRequireCheckHook
       > Check whether the following module can be imported: leetcode
       > Error detected while processing pre-vimrc command line:
       > E5108: Error executing lua ...in-leetcode.nvim-2024-06-27/lua/leetcode/config/init.lua:2: module 'plenary.path' not found:
       >  no field package.preload['plenary.path']
       >       no file './plenary/path.lua'
       >   no file '/nix/store/m8nihfxqggb2zgvvd7nd7rmd8rb3y52h-luajit-2.1.1713773202/share/luajit-2.1/plenary/path.lua'
       >  no file '/usr/local/share/lua/5.1/plenary/path.lua'
       >    no file '/usr/local/share/lua/5.1/plenary/path/init.lua'
       >       no file '/nix/store/m8nihfxqggb2zgvvd7nd7rmd8rb3y52h-luajit-2.1.1713773202/share/lua/5.1/plenary/path.lua'
       >     no file '/nix/store/m8nihfxqggb2zgvvd7nd7rmd8rb3y52h-luajit-2.1.1713773202/share/lua/5.1/plenary/path/init.lua'
       >        no file './plenary/path.so'
       >    no file '/usr/local/lib/lua/5.1/plenary/path.so'
       >       no file '/nix/store/m8nihfxqggb2zgvvd7nd7rmd8rb3y52h-luajit-2.1.1713773202/lib/lua/5.1/plenary/path.so'
       >        no file '/usr/local/lib/lua/5.1/loadall.so'
       >    no file './plenary.so'
       >         no file '/usr/local/lib/lua/5.1/plenary.so'
       >    no file '/nix/store/m8nihfxqggb2zgvvd7nd7rmd8rb3y52h-luajit-2.1.1713773202/lib/lua/5.1/plenary.so'
       >     no file '/usr/local/lib/lua/5.1/loadall.so'
       > stack traceback:
       >  [C]: in function 'require'
       >     ...in-leetcode.nvim-2024-06-27/lua/leetcode/config/init.lua:2: in main chunk
       >   [C]: in function 'require'
       >     ...ffvi-vimplugin-leetcode.nvim-2024-06-27/lua/leetcode.lua:1: in main chunk
       >   [C]: in function 'require'
       >     [string ":lua"]:1: in main chunk
       > Entering Ex mode.  Type "visual" to go to Normal mode.
       > :
       For full logs, run 'nix log /nix/store/xl6s5s6ahy5ih6bw1cpnnznplrh31scc-vimplugin-leetcode.nvim-2024-06-27.drv'.
error: 1 dependencies of derivation '/nix/store/6jir5jw9w1j6xnzf8sjhnkg5zliblabs-neovim-0.10.2.drv' failed to build

[GaetanLepage]

it does fail without plenary.nvim:

Ok, so it looks like transitive dependencies are indeed broken. cc @teto

[GaetanLepage]

Merging as is then