Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.gpy: 1.13.1 -> 1.13.2 #341238

Merged
merged 1 commit into from
Sep 18, 2024
Merged

python312Packages.gpy: 1.13.1 -> 1.13.2 #341238

merged 1 commit into from
Sep 18, 2024

Conversation

sarahec
Copy link
Contributor

@sarahec sarahec commented Sep 11, 2024 •
edited
Loading

Description of changes

  1. Version bump to 1.13.2
  2. Disabled one test that fails on Darwin x86_64 due to a rounding error
  3. Removed broken flag on Darwin

Re-do of #340866 due to a merging mistake (my bad)

cc: @NixOS/darwin-maintainers FYI for unlocking another broken package on Darwin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@sarahec
Copy link
Contributor Author

sarahec commented Sep 11, 2024

Result of nixpkgs-review pr 341238 run on aarch64-darwin 1

4 packages built:
  • python311Packages.gpy
  • python311Packages.gpy.dist
  • python312Packages.gpy
  • python312Packages.gpy.dist

@sarahec sarahec added the 6.topic: darwin Running or building packages on Darwin label Sep 11, 2024
@sarahec sarahec requested a review from bcdarwin September 11, 2024 19:56
@sarahec
Copy link
Contributor Author

sarahec commented Sep 11, 2024

Result of nixpkgs-review pr 341238 run on x86_64-darwin 1

4 packages built:
  • python311Packages.gpy
  • python311Packages.gpy.dist
  • python312Packages.gpy
  • python312Packages.gpy.dist

@sarahec
Copy link
Contributor Author

sarahec commented Sep 11, 2024

Result of nixpkgs-review pr 341238 run on x86_64-linux 1

4 packages built:
  • python311Packages.gpy
  • python311Packages.gpy.dist
  • python312Packages.gpy
  • python312Packages.gpy.dist

@sarahec
Copy link
Contributor Author

sarahec commented Sep 12, 2024

@bcdarwin and @viraptor you reviewed the previous version of this PR (before I screwed up a rebase onto master and closed it). May I ask for your review on this copy? It should be identical to the final version of that you reviewed in #340866.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 13, 2024
@sarahec
Copy link
Contributor Author

sarahec commented Sep 17, 2024

FP to keep up with HEAD

@sarahec
Copy link
Contributor Author

sarahec commented Sep 17, 2024

@NixOS/darwin-maintainers May I get a merge?

@gshpychka
Copy link
Contributor

Result of nixpkgs-review pr 341238 run on aarch64-darwin 1

4 packages built:
  • python311Packages.gpy
  • python311Packages.gpy.dist
  • python312Packages.gpy
  • python312Packages.gpy.dist

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Sep 17, 2024
@veprbl veprbl merged commit 78bf4de into NixOS:master Sep 18, 2024
26 of 27 checks passed
@sarahec sarahec deleted the gpy-on-darwin branch September 18, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshpychka gshpychka gshpychka approved these changes

@sikmir sikmir sikmir approved these changes

@bcdarwin bcdarwin Awaiting requested review from bcdarwin

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sarahec @gshpychka @sikmir @veprbl @wegank