awakened-poe-trade: init at 3.25.102 #341252
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
nezia1
changed the title
dotlambda
reviewed
Sep 11, 2024
nezia1
force-pushed
the
package-awakened-poe
branch
from
d0ee864 to
482e98e
Compare
|
Renamed the package to go under |
|
Commit message and PR title are wrong. |
nezia1
changed the title
nezia1
force-pushed
the
package-awakened-poe
branch
from
482e98e to
e98e53f
Compare
dotlambda
reviewed
Sep 11, 2024
| description = "Path of Exile trading app for price checking"; | ||
| homepage = "https://github.com/SnosMe/awakened-poe-trade"; | ||
| changelog = "https://github.com/SnosMe/awakened-poe-trade/releases/tag/v${version}"; | ||
| sourceProvenance = [ lib.sourceTypes.binaryBytecode ]; |
There was a problem hiding this comment.
I wasn't sure which option to use. Also, thank you for pointing out that I use pname way too much, I'll change that as well. Should anything else be changed in the code I committed, or would it be good after both these changes?
There was a problem hiding this comment.
Side-note: should I ignore this warning?
❯ ./result/bin/awakened-poe-trade
hook_thread_proc [101]: Could not set thread priority 49 for thread 0x7F0BBEC7F6C0!
load_input_helper [1827]: XkbGetKeyboard failed to locate a valid keyboard!
APPIMAGE env is not defined, current application is not an AppImage
e98e53f to
4c8f86f
Compare
ofborg
bot
added
8.has: package (new)
FliegendeWurst
added
the
12. first-time contribution
FliegendeWurst
approved these changes
Nov 3, 2024
wegank
added
the
12.approvals: 1
Comment on lines
+21
to
+22
| name = "${pname}-${version}"; | ||
| inherit src; |
There was a problem hiding this comment.
This fails evaluation for me. I think, didn't test, you need to do today:
Suggested change
| name = "${pname}-${version}"; | |
| inherit src; | |
| inherit pname src version; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I've added Awakened POE (a Path of Exile trading app for price checking).
I ended up packaging it for Nix using the AppImage, as the build process for the app involves using a build script from upstream that uses
import electron, which would use the Node.JS electron version and not take advantage of NixOS' dependency system. Upstream changes would likely need to be made to be packaged from source, or there is probably something I don't know (this is one of my first PRs to nixpkgs).Closes #302672.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.